966951 - "Group Call" is inactive when received call is hung up

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Loli (:lolimartinezcr)]

1.3
Gecko: e01ea79
Gaia: 539a25e

STR: 
1. Start a multicall (2 parties involved)
2. Join all the calls
3. Receive a new call. Previous multicall is on hold
4. Finish the latest incoming call received 


Actual:

After step 4, the multi-call seems to be frozen as in the attached, but tapping on 'Gruop call' it is recovered correctly.


EXPECTED
The managment of the calls should work fine.

Comment 1

[Jason Smith [:jsmith]]

Does this reproduce on 1.2?

Comment 2

[Loli (:lolimartinezcr)]

It's reproducible in 1.2

Comment 3

[Anthony Ricaud (:rik)]

In the case of two calls, not merged, when the active call is terminated, Gecko will automatically unpause the other call.
For conference group, Gecko is not doing that switch automatically now.

Hsin-Yi: I remember we talked about this but I can't remember if we should do a fix in Gecko or Gaia.

Comment 4

[Gabriele Svelto [:gsvelto] (PTO)]

(In reply to Anthony Ricaud (:rik) from comment #3)
> For conference group, Gecko is not doing that switch automatically now.

Thanks for the info. If we already have a Gecko bug for this please close this as a duplicate.

Comment 5

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Anthony Ricaud (:rik) from comment #3)
> In the case of two calls, not merged, when the active call is terminated,
> Gecko will automatically unpause the other call.

No, IIRC gecko doesn't do that.

> For conference group, Gecko is not doing that switch automatically now.

gecko doesn't automatically do this for conference call, either.

> 
> Hsin-Yi: I remember we talked about this but I can't remember if we should
> do a fix in Gecko or Gaia.

If we want to fix this, I'd expect doing this on gaia because I think this is too UX-dependent behaviuor. For example, my phone on hand doesn't have automatic switch in both case.

Comment 6

[Anthony Ricaud (:rik)]

My bad, wrong memories. In fact, I found where we're switching calls in Gaia and have a patch in preparation.

Comment 7

[Dylan Oliver [:doliver]]

triage: not blocking 1.3, bumping to 1.4 for consideration

Comment 8

[Anthony Ricaud (:rik)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/15955

I took the opportunity to move the exitCallScreen in an early return. PR best viewed with ?w=1

Comment 9

[Etienne Segonzac (:etienne)]

Comment on attachment 8370363 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/15955

tiny nit, r=me

Comment 10

[Anthony Ricaud (:rik)]

https://github.com/mozilla-b2g/gaia/commit/535baed5da28793eb01c0ee7a55d900d4398d93a

Comment 11

[Loli (:lolimartinezcr)]

Tested (02/10/2014) and working:
1.4
Gecko: e1f0669
Gaia: 7a317b0

Comment 13

[Jason Smith [:jsmith]]

Moving the blocking flag here - this was deemed an IOT blocker.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Please request approval-gaia-v1.3 on this patch when you get a chance.

Comment 15

[Anthony Ricaud (:rik)]

Comment on attachment 8370363 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/15955

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Conference call implementation
[User impact] if declined: User could think phone is broken after ending a call.
[Testing completed]: In master for 2+ months, new unit tests to cover the feature.
[Risk to taking this patch] (and alternatives if risky): None. It was an obvious case that we forgot to handle.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

v1.3: https://github.com/mozilla-b2g/gaia/commit/05f136fa6edbd30156030a86a13ef182dc4d40b5