nsSSLIOLayerAddToSocket doesn't init gTLSIntolerantSites

VERIFIED FIXED

Status

Core Graveyard
Security: UI
--
critical
VERIFIED FIXED
17 years ago
2 years ago

People

(Reporter: bbaetz, Assigned: bbaetz)

Tracking

({crash})

Other Branch
Other
All
crash

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

17 years ago
If you're talking to an https server over socks, the ssl io layer is called 
using nsSSLIOLayerAddToSocket. The firstTime init code for that doesn't set up 
the hash table, and so we crash.

Attaching the obvious patch.
(Assignee)

Comment 1

17 years ago
Created attachment 46918 [details] [diff] [review]
patch
(Assignee)

Comment 2

17 years ago
-> me. meant to do that when I filed it, sorry
Assignee: ssaux → bbaetz
Keywords: crash, patch, review

Comment 3

17 years ago
r= kaie

Comment 4

17 years ago
sr=darin
(Does this really need to be threadsafe?)

a=dbaron on behalf of drivers
It also might not be a bad idea to at least comment that the code is duplicated.
 Although it would be even better to factor it into a single function...
Hardware: All → Other
(Assignee)

Comment 7

17 years ago
This is only called from the socket transport thread, so it doesn't have to be
threadsafe. I'll let one of the NSS people (who have to check this in anyway)
decide whether to move the duplicated code into its own function.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 8

17 years ago
Verified on 2001-08-30-Trunk build on WinNT

Marking it verified as per above developer comments.
Status: RESOLVED → VERIFIED

Updated

14 years ago
Component: Security: UI → Security: UI
Product: PSM → Core
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.