967023 - nsXPCWrappedJSClass::GetNewOrUsed doesn't need to use an out param

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Andrew McCreight [:mccr8]]

It always returns NS_OK, so it could just return the value directly.  All callers null-check the out param result.

Ms2ger pointed this out.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: part 1 - Rename clazz to clasp in XPCWrappedNative::GetNewOrUsed.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: part 2 - Get rid of XPCWrappedJSClass::GetNewOrUsed out param.

Comment 3

[Andrew McCreight [:mccr8]]

https://tbpl.mozilla.org/?tree=Try&rev=5a96fefb4328

Comment 4

[Andrew McCreight [:mccr8]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/08efbd3dd17f
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/3223d3bfdcd0

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/08efbd3dd17f
https://hg.mozilla.org/mozilla-central/rev/3223d3bfdcd0