Closed
Bug 967086
Opened 9 years ago
Closed 9 years ago
toolkit/components/crashmonitor/nsCrashMonitor.js: WARNING: no preprocessor directives found
Categories
(Toolkit :: General, defect)
Toolkit
General
Tracking
()
RESOLVED
FIXED
mozilla30
People
(Reporter: ttaubert, Assigned: eveenstra26)
References
Details
(Whiteboard: [good first bug][mentor=ttaubert][lang=Makefile?])
Attachments
(1 file)
720 bytes,
patch
|
ttaubert
:
review+
|
Details | Diff | Splinter Review |
When building, you see the following warning: toolkit/components/crashmonitor/nsCrashMonitor.js: WARNING: no preprocessor directives found In toolkit/components/crashmonitor/moz.build we should move nsCrashMonitor.js out of EXTRA_PP_COMPONENTS into EXTRA_COMPONENTS.
Assignee | ||
Comment 1•9 years ago
|
||
I'll take this one. Is it just moving the file name from the EXTRA_PP_COMPONENTS array to the EXTRA_COMPONENTS array?
Reporter | ||
Comment 2•9 years ago
|
||
Yes, exactly. I'll assign this bug to you. Thanks!
Assignee: nobody → eveenstra26
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•9 years ago
|
||
Is it okay to delete the empty EXTRA_PP_COMPONENTS array?
Reporter | ||
Comment 4•9 years ago
|
||
Yes, please remove it.
Assignee | ||
Comment 5•9 years ago
|
||
Attachment #8372536 -
Flags: review?(ttaubert)
Reporter | ||
Comment 6•9 years ago
|
||
Comment on attachment 8372536 [details] [diff] [review] bug967086.patch Review of attachment 8372536 [details] [diff] [review]: ----------------------------------------------------------------- Great, thanks!
Attachment #8372536 -
Flags: review?(ttaubert) → review+
Assignee | ||
Comment 7•9 years ago
|
||
Good for checkin-needed?
Comment 9•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/cd60f4a9ca8e
Keywords: checkin-needed
Comment 10•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cd60f4a9ca8e
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in
before you can comment on or make changes to this bug.
Description
•