967086 - toolkit/components/crashmonitor/nsCrashMonitor.js: WARNING: no preprocessor directives found

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

When building, you see the following warning:

toolkit/components/crashmonitor/nsCrashMonitor.js: WARNING: no preprocessor directives found

In toolkit/components/crashmonitor/moz.build we should move nsCrashMonitor.js out of EXTRA_PP_COMPONENTS into EXTRA_COMPONENTS.

Comment 1

[Emerson Veenstra [:emerson]]

I'll take this one. Is it just moving the file name from the EXTRA_PP_COMPONENTS array to the EXTRA_COMPONENTS array?

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Yes, exactly. I'll assign this bug to you. Thanks!

Comment 3

[Emerson Veenstra [:emerson]]

Is it okay to delete the empty EXTRA_PP_COMPONENTS array?

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

Yes, please remove it.

Comment 5

[Emerson Veenstra [:emerson]]

Attachment: bug967086.patch

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8372536 [details] [diff] [review]
bug967086.patch

Review of attachment 8372536 [details] [diff] [review]:
-----------------------------------------------------------------

Great, thanks!

Comment 7

[Emerson Veenstra [:emerson]]

Good for checkin-needed?

Comment 8

[Tim Taubert [:ttaubert] (inactive)]

Yes :)

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cd60f4a9ca8e

Comment 10

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/cd60f4a9ca8e