toolkit/components/crashmonitor/nsCrashMonitor.js: WARNING: no preprocessor directives found

RESOLVED FIXED in mozilla30

Status

()

Toolkit
General
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: ttaubert, Assigned: emerson)

Tracking

Trunk
mozilla30
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=ttaubert][lang=Makefile?])

Attachments

(1 attachment)

When building, you see the following warning:

toolkit/components/crashmonitor/nsCrashMonitor.js: WARNING: no preprocessor directives found

In toolkit/components/crashmonitor/moz.build we should move nsCrashMonitor.js out of EXTRA_PP_COMPONENTS into EXTRA_COMPONENTS.
(Assignee)

Comment 1

4 years ago
I'll take this one. Is it just moving the file name from the EXTRA_PP_COMPONENTS array to the EXTRA_COMPONENTS array?
Yes, exactly. I'll assign this bug to you. Thanks!
Assignee: nobody → eveenstra26
Status: NEW → ASSIGNED
(Assignee)

Comment 3

4 years ago
Is it okay to delete the empty EXTRA_PP_COMPONENTS array?
Yes, please remove it.
(Assignee)

Comment 5

4 years ago
Created attachment 8372536 [details] [diff] [review]
bug967086.patch
Attachment #8372536 - Flags: review?(ttaubert)
Comment on attachment 8372536 [details] [diff] [review]
bug967086.patch

Review of attachment 8372536 [details] [diff] [review]:
-----------------------------------------------------------------

Great, thanks!
Attachment #8372536 - Flags: review?(ttaubert) → review+
(Assignee)

Comment 7

4 years ago
Good for checkin-needed?
Yes :)
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/cd60f4a9ca8e
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/cd60f4a9ca8e
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.