Closed Bug 967086 Opened 10 years ago Closed 10 years ago

toolkit/components/crashmonitor/nsCrashMonitor.js: WARNING: no preprocessor directives found

Categories

(Toolkit :: General, defect)

Product:
Toolkit
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla30

People

(Reporter: ttaubert, Assigned: eveenstra26)

References

Details

(Whiteboard: [good first bug][mentor=ttaubert][lang=Makefile?])

Attachments

(1 file)

bug967086.patch
720 bytes, patch
ttaubert
: review+
Details | Diff | Splinter Review 
When building, you see the following warning:

toolkit/components/crashmonitor/nsCrashMonitor.js: WARNING: no preprocessor directives found

In toolkit/components/crashmonitor/moz.build we should move nsCrashMonitor.js out of EXTRA_PP_COMPONENTS into EXTRA_COMPONENTS.
I'll take this one. Is it just moving the file name from the EXTRA_PP_COMPONENTS array to the EXTRA_COMPONENTS array?
Yes, exactly. I'll assign this bug to you. Thanks!
Assignee: nobody → eveenstra26
Status: NEW → ASSIGNED
Is it okay to delete the empty EXTRA_PP_COMPONENTS array?
Yes, please remove it.
Attached patch bug967086.patch — — Splinter Review 

        Attachment #8372536 -
        Flags: review?(ttaubert)

    
    

    
  
Comment on attachment 8372536 [details] [diff] [review]
bug967086.patch

Review of attachment 8372536 [details] [diff] [review]:
-----------------------------------------------------------------

Great, thanks!

        Attachment #8372536 -
        Flags: review?(ttaubert) → review+

    
    

    
  
Good for checkin-needed?

    
    

    
  
Yes :)
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/cd60f4a9ca8e
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla30

          You need to log in
          before you can comment on or make changes to this bug.