967098 - Expose settings to twiddle displayport prefs

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

For bug 942750, one of the approaches we want to try is to adjust some of the displayport calculation prefs (and maybe add some new ones) so that the reverse-scrolling case checkerboards less. This bug will track that work.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Part 1 - Pref-ify some more knobs in the displayport calculation

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Part 2 - Expose prefs in Gaia (gecko patch)

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Part 3 - Expose prefs in Gaia (Gaia patch)

Comment 4

[Botond Ballo [:botond]]

Comment on attachment 8369597 [details] [diff] [review]
Part 1 - Pref-ify some more knobs in the displayport calculation

Review of attachment 8369597 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/ipc/AsyncPanZoomController.cpp
@@ +170,5 @@
>  
>  /**
> + * Whether or not to use the estimated paint duration as a factor when projecting
> + * the displayport in the direction of scrolling. If this value is set to false,
> + * a constant 50ms paint time is used; this can be scaled as desired using the

It wasn't immediately clear to me that "this" refers to "the amount by which the displayport is projected" - can we just say the latter?

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8369603 [details] [diff] [review]
Part 3 - Expose prefs in Gaia (Gaia patch)

Review of attachment 8369603 [details] [diff] [review]:
-----------------------------------------------------------------

You need a few more data-l10n-id

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Attachment: Part 3 - Expose prefs in Gaia (Gaia patch) (v2)

Comment 7

[Kartikaya Gupta (email:[e-mail])]

https://github.com/mozilla-b2g/gaia/pull/15931

Comment 8

[Kartikaya Gupta (email:[e-mail])]

I believe this is wanted on 1.3 for trying to fix bug 942750.

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/4a9a286c7af8b03aacdbdecbadc05eca3cbec868

Comment 10

[Kartikaya Gupta (email:[e-mail])]

remote:   https://hg.mozilla.org/integration/b2g-inbound/rev/66cba27e5910
remote:   https://hg.mozilla.org/integration/b2g-inbound/rev/9a61317c7ba1

Comment 11

[[:fabrice] Fabrice Desré]

I pushed a followup to fix OSX burning and also correct what I believe was a bug in the first patch:
https://hg.mozilla.org/integration/b2g-inbound/rev/7d97d8605cfa

Comment 12

[Kartikaya Gupta (email:[e-mail])]

Good catch, thanks!

Comment 13

[Kevin Grandon :kgrandon]

Attachment: Gaia follow-up patch - select box styling

Current select box does not follow gaia standards. Vivien, would you have a quick minute to review?

Comment 14

[Kevin Grandon :kgrandon]

Landed follow-up: https://github.com/mozilla-b2g/gaia/commit/db75b307f579fa1e4083613e529c603003636abc

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/66cba27e5910
https://hg.mozilla.org/mozilla-central/rev/9a61317c7ba1
https://hg.mozilla.org/mozilla-central/rev/7d97d8605cfa

Comment 16

[Preeti Raghunath(:Preeti)]

blocking a blocker and hence 1.3+

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/e96afeba8e9a
https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/ecdfd19e9134
https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/2ba5f350cfc8

v1.3: 55f1ce0f9d4fb132c9607c54d45cb51bfae0509b + b4ce88b624584f93028091e059c0d179e8231fa6