Merge apps.tags.models.Tag and apps.tags.models.TagStat

VERIFIED FIXED in 2014-02-11

Status

Marketplace
Code Quality
P2
normal
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: mat, Assigned: mat)

Tracking

2014-02-11
x86_64
Linux
Points:
---

Details

(Assignee)

Description

4 years ago
TagStat model only has 2 fields: a OneToOneField to Tag, set as primary_key, and num_addons, an IntegerField. We do some crazy signals stuff to create TagStat instances dynamically, we should just stop and merge the two in the Tag model.

This blocks bug 850885 - we get weird failures that are hard to debug with 1.6 with the current models.
(Assignee)

Updated

4 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

4 years ago
Not sure what STR to provide for this. This is an internal re-factoring that might affect anything that uses tag on AMO or Marketplace.

I've looked at https://addons-dev.allizom.org/en-US/firefox/tags/top and it seems fine. If you can think of any other test to perform, do it :)
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2014-02-11

Comment 2

4 years ago
I also checked adding a tag to an app and confirmed that it shows upon searching for that tag.Removing the tag and triggering an ES reindex removed the app from the search results.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.