Fix fix_macosx_stack.py

RESOLVED FIXED in mozilla30

Status

()

Core
XPCOM
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

Trunk
mozilla30
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
There are at least two problems here. First, addresses use lower case letters, but the script is looking for upper case letters, so any address with a letter doesn't get converted.  Second, when you run atos, it spews out a warning, which confuses the script:

 -- 
Warning: /usr/bin/atos is moving and will be removed from a future OS X release.
It is now available in the Xcode developer tools to be invoked via: `xcrun atos`
To silence this warning, pass the '-d' command-line flag to this tool.
 -- 

I should either figure out how this xcrun thing should work (though maybe that will break older versions of OSX?), or just kick the can down the road and pass in '-d'.
(Assignee)

Comment 1

4 years ago
With those fixed, the script actually seems to fix every line properly, at least in a simple test.

Comment 2

4 years ago
Can you upload your patch?
(Assignee)

Comment 3

4 years ago
Created attachment 8369668 [details] [diff] [review]
Fix fix_macosx_stack.py

Comment 4

4 years ago
Regexp change looks good. For the "xcrun" change, maybe we can find someone with 10.8 to check that it still works on 10.8?
(Assignee)

Comment 5

4 years ago
jwatt, njn said you know stuff about Xcode?  Do you have any idea what version "xcrun" was introduced by any chance?  I want to know if I can just unilaterally change a script over to do "xcrun atos" instead of "atos".
Flags: needinfo?(jwatt)
Sorry, that's not something I know.
Flags: needinfo?(jwatt)
xcrun lives on my somewhat-oldish XCode installation (4.4?  4.6?), on OS X 10.7.5.  The in-tree mozboot uses it.  I think it's safe to say it's been around for a while.
(Assignee)

Updated

4 years ago
Summary: Fix fix_macosx_stack.py to work on 10.9 → Fix fix_macosx_stack.py to work
(Assignee)

Updated

4 years ago
Summary: Fix fix_macosx_stack.py to work → Fix fix_macosx_stack.py
(Assignee)

Updated

4 years ago
Attachment #8369668 - Flags: review?(jruderman)
(Assignee)

Comment 8

4 years ago
Comment on attachment 8369668 [details] [diff] [review]
Fix fix_macosx_stack.py

Maybe njn can get to this first.
Attachment #8369668 - Flags: review?(n.nethercote)
Attachment #8369668 - Flags: review?(n.nethercote) → review+
(Assignee)

Updated

4 years ago
Attachment #8369668 - Flags: review?(jruderman)
https://hg.mozilla.org/mozilla-central/rev/cff3bc2d1538
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.