967298 - make nsIX509CertList instantiable

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[[:mmc] Monica Chew (no longer reading bugmail)]

+++ This bug was initially created as a clone of Bug #966557 +++

+++ This bug was initially created as a clone of Bug #928536 +++

See https://bugzilla.mozilla.org/show_bug.cgi?id=928536#c51

Comment 1

[[:mmc] Monica Chew (no longer reading bugmail)]

Attachment: certlist

Comment 2

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Comment on attachment 8369729 [details] [diff] [review]
certlist

Review of attachment 8369729 [details] [diff] [review]:
-----------------------------------------------------------------

::: security/manager/ssl/public/nsIX509CertList.idl
@@ +21,5 @@
>  };
>  
>  %{C++
>  
> +#define NS_X509CERTLIST_CID { /* 959fb165-6517-487f-ab9b-d8913be53197 */ \

NIT: fix alignment of "\".

::: security/manager/ssl/src/nsNSSCertificate.h
@@ +83,5 @@
>    // certList is adopted 
>    nsNSSCertList(insanity::pkix::ScopedCERTCertList& certList,
>                  const nsNSSShutDownPreventionLock& proofOfLock);
>  
> +  // NULL constructor

You do not need this comment. (Also it would be "default" not "NULL".)

Comment 3

[[:mmc] Monica Chew (no longer reading bugmail)]

Fixed and checked in.

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/e99fd1631c09

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e99fd1631c09