Closed Bug 967302 Opened 6 years ago Closed 5 years ago

`mochitest-chrome dom/tests/mochitest/webapps` leaks chrome://global/skin/icons/webapps-64.png

Categories

(Firefox Graveyard :: Webapp Runtime, defect, P1)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 33

People

(Reporter: myk, Assigned: fzzzy)

Details

Attachments

(1 file)

`mochitest-chrome dom/tests/mochitest/webapps` leaks chrome://global/skin/icons/webapps-64.png in my debug build on my Mac:

> ./mach build && ./mach mochitest-chrome dom/tests/mochitest/webapps
 …
 0:45.09 117 INFO Passed:  68
 0:45.09 118 INFO Failed:  0
 0:45.09 119 INFO Todo:    1
 …
 0:51.63 Leaked URLs:
 0:51.63   chrome://global/skin/icons/webapps-64.png
 …
 0:51.77 TEST-INFO | leakcheck | leaked 1 DecodeRequest (48 bytes)
TEST-INFO | leakcheck | leaked 1 FrameSequence (16 bytes)
TEST-INFO | leakcheck | leaked 1 Mutex (24 bytes)
TEST-INFO | leakcheck | leaked 1 RasterImage (392 bytes)
TEST-INFO | leakcheck | leaked 1 ReentrantMonitor (32 bytes)
TEST-INFO | leakcheck | leaked 2 gfxASurface (96 bytes)
TEST-INFO | leakcheck | leaked 1 imgCacheEntry (56 bytes)
TEST-INFO | leakcheck | leaked 1 imgLoader (256 bytes)
TEST-INFO | leakcheck | leaked 1 imgMemoryReporter (32 bytes)
TEST-INFO | leakcheck | leaked 1 imgRequest (240 bytes)
TEST-INFO | leakcheck | leaked 2 imgStatusTracker (208 bytes)
TEST-INFO | leakcheck | leaked 1 mozilla::image::ImageURL (296 bytes)
TEST-INFO | leakcheck | leaked 1 nsAuthURLParser (24 bytes)
TEST-INFO | leakcheck | leaked 1 nsBasePrincipal (24 bytes)
TEST-INFO | leakcheck | leaked 1 nsPrincipal (48 bytes)
TEST-INFO | leakcheck | leaked 1 nsProperties (16 bytes)
TEST-INFO | leakcheck | leaked 1 nsStandardURL (248 bytes)
TEST-INFO | leakcheck | leaked 3 nsStringBuffer (24 bytes)
TEST-INFO | leakcheck | leaked 1 nsSupportsCStringImpl (40 bytes)
TEST-INFO | leakcheck | leaked 5 nsTArray_base (40 bytes)
 0:51.77 TEST-UNEXPECTED-FAIL | leakcheck | 2160 bytes leaked (DecodeRequest, FrameSequence, Mutex, RasterImage, ReentrantMonitor, ...)
 0:51.77 runtests.py | Running tests: end.
 0:51.77 TEST-UNEXPECTED-FAIL | leakcheck | 2160 bytes leaked (DecodeRequest, FrameSequence, Mutex, RasterImage, ReentrantMonitor, ...)
Assignee: nobody → dpreston
Priority: -- → P1
I don't seem to see this anymore, so I think we can resolve it.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WORKSFORME
It's back!
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
The leak is due to the XUL alert we show at the end of an installation. Commenting it out fixes the problem.
A simple solution would be mocking the Alerts service.
Attached patch PatchSplinter Review
Attachment #8454205 - Flags: review?(myk)
Comment on attachment 8454205 [details] [diff] [review]
Patch

Review of attachment 8454205 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch!
Attachment #8454205 - Flags: review?(myk) → review+
https://hg.mozilla.org/mozilla-central/rev/4625ba9d9a09
Status: REOPENED → RESOLVED
Closed: 6 years ago5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.