Closed
Bug 967370
Opened 7 years ago
Closed 7 years ago
Remove duplication in UITour browser chrome tests
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 30
People
(Reporter: MattN, Assigned: MattN)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
15.59 KB,
patch
|
Unfocused
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Bug 956202 by duplicating about 70 lines in every UITour test file. I used 3-way merges to make sure I didn't miss differences. browser/modules/test/browser_UITour.js | 74 +----------------------------- browser/modules/test/browser_UITour2.js | 68 +---------------------------- browser/modules/test/browser_UITour3.js | 68 +---------------------------- browser/modules/test/browser_UITour_sync.js | 66 +--------------------------- browser/modules/test/head.js | 72 ++++++++++++++++++++++++++++++ 5 files changed, 79 insertions(+), 269 deletions(-)
Attachment #8369871 -
Flags: review?(bmcbride)
Updated•7 years ago
|
Attachment #8369871 -
Flags: review?(bmcbride) → review+
Assignee | ||
Comment 1•7 years ago
|
||
Thanks! https://hg.mozilla.org/integration/fx-team/rev/cea89064bf58
status-firefox29:
--- → affected
Flags: in-testsuite-
Assignee | ||
Comment 2•7 years ago
|
||
Comment on attachment 8369871 [details] [diff] [review] v.1 Dedupe two functions [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 956202 User impact if declined: None, the developer impact is that Aurora and m-c test files will be different making test uplift hard. Testing completed (on m-c, etc.): m-c now. Test-only change Risk to taking this patch (and alternatives if risky): Test-only cleanup String or IDL/UUID changes made by this patch: None
Attachment #8369871 -
Flags: approval-mozilla-aurora?
Updated•7 years ago
|
Attachment #8369871 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 3•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cea89064bf58
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
Assignee | ||
Comment 4•7 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/b23708e5db18
Assignee | ||
Updated•7 years ago
|
Updated•7 years ago
|
status-firefox30:
--- → fixed
Updated•7 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•