Closed Bug 967388 Opened 10 years ago Closed 10 years ago

Replace Yahoo icon with hi-dpi version, switch to Yahoo! Metro version

Categories

(Mozilla Localizations :: Other, defect)

Product:
Mozilla Localizations
Component:
Other
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: flod, Assigned: flod)

References

Details

This bug will track the updates to Yahoo searchplugins across locales:
* update desktop Yahoo searchplugin with hi-dpi icon
* switch to metro version for Yahoo with hi-dpi icon plus new 74px icon, and updated search parameter

Reference bug for images: bug 936198
Reference bug for custom search code: bug 942024 (waiting for confirmation)

Plan is to land directly a fix on mozilla-aurora and l10n-central and reference all changesets in this tracking bug.

For a limited set of locales (de, fr, es-ES, pt-BR, it) I'm going to file individual bugs with patch+review and land on mozilla-beta.
Depends on: 967395
Depends on: 967396
Depends on: 967397
Depends on: 967398
Depends on: 967399
Fixed all locales using en-US yahoo.xml (updated reference in metrolist.txt from yahoo to yahoometrofx)

Patch landed on mozilla-aurora and merged down to l10n-central
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ach/rev/2509c092e0af
http://hg.mozilla.org/releases/l10n/mozilla-aurora/af/rev/b0fdc00b89a7
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ak/rev/1ebba4faab5f
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ar/rev/b3308c8ca4bb
http://hg.mozilla.org/releases/l10n/mozilla-aurora/az/rev/be93011fa072
http://hg.mozilla.org/releases/l10n/mozilla-aurora/be/rev/bfc5bea37b48
http://hg.mozilla.org/releases/l10n/mozilla-aurora/bn-BD/rev/f11c75aead32
http://hg.mozilla.org/releases/l10n/mozilla-aurora/bs/rev/fc99767d08b5
http://hg.mozilla.org/releases/l10n/mozilla-aurora/el/rev/3dffa49bc972
http://hg.mozilla.org/releases/l10n/mozilla-aurora/eo/rev/87b721cafcb2
http://hg.mozilla.org/releases/l10n/mozilla-aurora/eu/rev/df25475c5c29
http://hg.mozilla.org/releases/l10n/mozilla-aurora/fa/rev/0e4f10fd5623
http://hg.mozilla.org/releases/l10n/mozilla-aurora/he/rev/d46dc04b9241
http://hg.mozilla.org/releases/l10n/mozilla-aurora/hr/rev/2af4bc304cf2
http://hg.mozilla.org/releases/l10n/mozilla-aurora/hy-AM/rev/32949acafa50
http://hg.mozilla.org/releases/l10n/mozilla-aurora/is/rev/8544f1f7c992
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ka/rev/917985297063
http://hg.mozilla.org/releases/l10n/mozilla-aurora/km/rev/758edcd4dd3b
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ku/rev/9fd378b601ee
http://hg.mozilla.org/releases/l10n/mozilla-aurora/lg/rev/42403c64aafa
http://hg.mozilla.org/releases/l10n/mozilla-aurora/lv/rev/a20719df6a29
http://hg.mozilla.org/releases/l10n/mozilla-aurora/mk/rev/e2a600cb5903
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ms/rev/5c65bccff100
http://hg.mozilla.org/releases/l10n/mozilla-aurora/my/rev/cd96ddabef6c
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ro/rev/50e42e40dea7
http://hg.mozilla.org/releases/l10n/mozilla-aurora/rw/rev/1100f3f38106
http://hg.mozilla.org/releases/l10n/mozilla-aurora/si/rev/216ae60f7e5e
http://hg.mozilla.org/releases/l10n/mozilla-aurora/sq/rev/468824cbc414
http://hg.mozilla.org/releases/l10n/mozilla-aurora/sw/rev/a5477e3fcecf
http://hg.mozilla.org/releases/l10n/mozilla-aurora/th/rev/74ff26e299cd
http://hg.mozilla.org/releases/l10n/mozilla-aurora/tn/rev/c4408e445667
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ur/rev/79f85d08eb62
http://hg.mozilla.org/releases/l10n/mozilla-aurora/wo/rev/3d955b95c3b7
http://hg.mozilla.org/releases/l10n/mozilla-aurora/zu/rev/befde907f00a
Blocks: 972769
List of locales still needing an update on aurora: an, as, ast, bn-IN, br, cy, en-GB, es-AR, es-CL, es-MX, ff, fi, fy-NL, ga-IE, gd, gl, gu-IN, hi-IN, id, kn, lij, mai, mr, nb-NO, oc, or, pa-IN, rm, son, sv-SE, ta, te, zh-TW.

Locale with pending bugs for beta: de, es-ES, fr, pt-BR.
Fixed a few locales and already some doubts, so I'm going to stop for a while.
http://hg.mozilla.org/releases/l10n/mozilla-aurora/an/rev/62a013cff502
http://hg.mozilla.org/releases/l10n/mozilla-aurora/as/rev/fb9f0e57b035
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ast/rev/dbc1ddf0eecd
http://hg.mozilla.org/releases/l10n/mozilla-aurora/bn-IN/rev/992f5ce06488
http://hg.mozilla.org/releases/l10n/mozilla-aurora/br/rev/f827fa61db94
http://hg.mozilla.org/releases/l10n/mozilla-aurora/cy/rev/dca85a8cb030

@mconnor
bn-IN: mozParam is just "fr". I checked the history of this file and it's very old. 
Should I just update the value in these cases or it's wanted? I expect to find similar cases among Indian languages.

br: Yahoo France, but without MozParam. Should I add it when it's missing?
Flags: needinfo?(mconnor)
More landings
http://hg.mozilla.org/releases/l10n/mozilla-aurora/en-GB/rev/89ff5e7028d4
http://hg.mozilla.org/releases/l10n/mozilla-aurora/es-AR/rev/578549c63a40
http://hg.mozilla.org/releases/l10n/mozilla-aurora/es-CL/rev/ad7fd157f48e
http://hg.mozilla.org/releases/l10n/mozilla-aurora/es-MX/rev/ec94d8fbfc26
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ff/rev/162cc306bc07
http://hg.mozilla.org/releases/l10n/mozilla-aurora/fi/rev/1003db7ca690
http://hg.mozilla.org/releases/l10n/mozilla-aurora/fy-NL/rev/5690b94dacb9
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ga-IE/rev/750782106f44
http://hg.mozilla.org/releases/l10n/mozilla-aurora/gd/rev/18381708bb82
http://hg.mozilla.org/releases/l10n/mozilla-aurora/gl/rev/9091a061efa6
http://hg.mozilla.org/releases/l10n/mozilla-aurora/gu-IN/rev/6e6e1143b844
http://hg.mozilla.org/releases/l10n/mozilla-aurora/hi-IN/rev/9edcaecfff6f
http://hg.mozilla.org/releases/l10n/mozilla-aurora/id/rev/e96c7546717d
http://hg.mozilla.org/releases/l10n/mozilla-aurora/kn/rev/45e264d210c8
http://hg.mozilla.org/releases/l10n/mozilla-aurora/lij/rev/e064db591a28
http://hg.mozilla.org/releases/l10n/mozilla-aurora/mai/rev/8f4e47d7cfcc
http://hg.mozilla.org/releases/l10n/mozilla-aurora/mr/rev/0329753b105b
http://hg.mozilla.org/releases/l10n/mozilla-aurora/nb-NO/rev/b31cb973e9d7
http://hg.mozilla.org/releases/l10n/mozilla-aurora/oc/rev/3c1a02a7efe8
http://hg.mozilla.org/releases/l10n/mozilla-aurora/or/rev/a3d6094bfe73
http://hg.mozilla.org/releases/l10n/mozilla-aurora/pa-IN/rev/1bfc7636378e
http://hg.mozilla.org/releases/l10n/mozilla-aurora/rm/rev/5c45b28b1ae9
http://hg.mozilla.org/releases/l10n/mozilla-aurora/son/rev/3529e86acbfd
http://hg.mozilla.org/releases/l10n/mozilla-aurora/sv-SE/rev/965891e4c7cf
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ta/rev/887ee909a685
http://hg.mozilla.org/releases/l10n/mozilla-aurora/te/rev/86d68bd228e1
http://hg.mozilla.org/releases/l10n/mozilla-aurora/zh-TW/rev/816ddd54ac08
@mconnor

To summarize, these are the problems I noticed

bn-IN, mr: mozparam fr is set to "fr", not "yahoo-fr". At the moment, also metro version has the same value
br: mozparam fr is completely missing
zh-TW: mozparam is different ("ffds1" instead of "yahoo-fr"). I didn't touch that and copied the same value over the metro version

If you can tell me what to do with these 4 locales, and review the 4 pending patches on beta, this bug is complete.
(In reply to Francesco Lodolo [:flod] from comment #5)
> @mconnor
> 
> To summarize, these are the problems I noticed
> 
> bn-IN, mr: mozparam fr is set to "fr", not "yahoo-fr". At the moment, also
> metro version has the same value

bn-IN has been broken from the time of initial landing (2008) in bug 398992. Axel caught it on initial review, but the followup patch had fr instead of yahoo-fr.  This should be fixed, and we should grumble that this has likely cost us some credit.  mr was copied from bn-IN in bug 410783, so has the same bug.

> br: mozparam fr is completely missing

Not sure how that got missed.  Please fix it.

> zh-TW: mozparam is different ("ffds1" instead of "yahoo-fr"). I didn't touch
> that and copied the same value over the metro version

That changed, no explanation given, in 2008 (bug 445093) as well.  The intent appears to have been to set fr=ffds1, and since we don't have a ffds1 mozparam in our builds this is probably just straight up broken.

> If you can tell me what to do with these 4 locales, and review the 4 pending
> patches on beta, this bug is complete.

Based on what I know, everything not-Japan should be on the same param, so let's fix them all.  I'll get those reviews done next.
Flags: needinfo?(mconnor)
Patches landed for fr, pt-BR, es-ES. Only missing German now.
Also: should we do something about Japanese and their old icon?
No, we should not.  That's the correct icon for Yahoo! Japan (tl;dr it's not the same company as Yahoo!, though there's a relationship there).
(In reply to Mike Connor [:mconnor] from comment #11)
> No, we should not.  That's the correct icon for Yahoo! Japan (tl;dr it's not
> the same company as Yahoo!, though there's a relationship there).

Clarification: "do something" didn't mean change the icon, I meant having the current icon in hi-dpi for desktop and 74px for Metro (with eventually a different MozParam than desktop).
Oh, almost certainly yes.  Doesn't need to be in this bug though, since it's isolated and will involve chasing down different people.
Depends on: 975796
Filed bug 975796 for Japanese, I can take care of the patch as long as we find the icons.
Fixed Japanese for desktop (no Metro at this point).
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.