Fix a few widget leftovers in RequestsMenuView after bug 951633

RESOLVED FIXED in Firefox 30

Status

()

Firefox
Developer Tools: Netmonitor
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: vporof, Assigned: vporof)

Tracking

unspecified
Firefox 30
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Bug 951633 made a few changes to the widgets APIs. There are two small things in RequestsMenuView that haven't been updated:
* maintainSelectionVisible is a shared property now across all widget implementations
* a custom predicate should be supplied at initialization if sorting by values isn't desired
(Assignee)

Comment 1

4 years ago
Created attachment 8369933 [details] [diff] [review]
v1
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #8369933 - Flags: review?(past)
Comment on attachment 8369933 [details] [diff] [review]
v1

Review of attachment 8369933 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8369933 - Flags: review?(past) → review+
(Assignee)

Comment 3

4 years ago
https://hg.mozilla.org/integration/fx-team/rev/f989ab51fa44
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/f989ab51fa44
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 30

Updated

4 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.