Closed
Bug 967411
Opened 11 years ago
Closed 11 years ago
Fix a few widget leftovers in RequestsMenuView after bug 951633
Categories
(DevTools :: Netmonitor, defect)
DevTools
Netmonitor
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 30
People
(Reporter: vporof, Assigned: vporof)
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
1.50 KB,
patch
|
past
:
review+
|
Details | Diff | Splinter Review |
Bug 951633 made a few changes to the widgets APIs. There are two small things in RequestsMenuView that haven't been updated:
* maintainSelectionVisible is a shared property now across all widget implementations
* a custom predicate should be supplied at initialization if sorting by values isn't desired
|
Assignee | |
Comment 1•11 years ago
|
||
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8369933 [details] [diff] [review]
v1
Review of attachment 8369933 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM.
Attachment #8369933 -
Flags: review?(past) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Whiteboard: [fixed-in-fx-team]
|
||
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 30
|
||
Updated•11 years ago
|
Whiteboard: [qa-]
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•