967432 - Permanent Orange: TEST-UNEXPECTED-FAIL | test-message-header.js | test-message-header.js::test_a11y_attrs

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Mark Banner (:standard8)]

SUMMARY-UNEXPECTED-FAIL | C:\slave\test\build\mozmill\message-header\test-message-header.js | test-message-header.js::test_a11y_attrs
  EXCEPTION: headerAccessible.name for Subject was 'null'; expected 'Subjec: This is a really, really, really, really, really, really, really, really, long subject.'
    at: test-message-header.js line 997
       verify_header_a11y test-message-header.js 997
       test_a11y_attrs test-message-header.js 1022
       Runner.prototype.wrapper frame.js 585
       Runner.prototype._runTestModule frame.js 655
       Runner.prototype.runTestModule frame.js 701
       Runner.prototype.runTestDirectory frame.js 525
       runTestDirectory frame.js 707
       Bridge.prototype._execFunction server.js 179
       Bridge.prototype.execFunction server.js 183

This is on Windows & Linux (Mac has accessibility disabled due to the same failure but that was present from the start of accessibility being enabled on Mac - see bug 862238).

The regression here is from bug 963105 - I've verified it using try server fixed to before & after revisions.

Potentially useful links:

http://hg.mozilla.org/comm-central/annotate/2f2fa58f41a7/mail/test/mozmill/message-header/test-message-header.js#l981

http://hg.mozilla.org/comm-central/annotate/2f2fa58f41a7/mail/test/mozmill/message-header/test-message-header.js#l892

http://hg.mozilla.org/comm-central/annotate/2f2fa58f41a7/mail/base/content/msgHdrViewOverlay.xul#l411

Comment 1

[Mark Banner (:standard8)]

Also screenshot and some more info:

http://clicky.visophyte.org/tools/arbpl-mozmill-standalone/?log=http://ftp.mozilla.org/pub/mozilla.org/thunderbird/tinderbox-builds/comm-central-win32/1391468047/comm-central_xp-ix_test-mozmill-bm71-tests1-windows-build96.txt.gz

Comment 2

[Legacy TBPL/Treeherder Robot]

Standard8
https://tbpl.mozilla.org/php/getParsedLog.php?id=34055505&tree=Thunderbird-Trunk
Ubuntu VM 12.04 comm-central opt test mozmill on 2014-02-04 04:05:23
revision: b57fc63e6aba
slave: tst-linux32-spot-181

TEST-UNEXPECTED-FAIL | /builds/slave/test/build/mozmill/message-header/test-message-header.js | test-message-header.js::test_a11y_attrs
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run

Comment 3

[Legacy TBPL/Treeherder Robot]

RyanVM
https://tbpl.mozilla.org/php/getParsedLog.php?id=34086823&tree=Thunderbird-Trunk
Ubuntu VM 12.04 x64 comm-central debug test mozmill on 2014-02-04 12:59:49
revision: 94ac2c1ecba7
slave: tst-linux64-spot-452

TEST-UNEXPECTED-FAIL | /builds/slave/test/build/mozmill/message-header/test-message-header.js | test-message-header.js::test_a11y_attrs
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run

Comment 4

[Legacy TBPL/Treeherder Robot]

RyanVM
https://tbpl.mozilla.org/php/getParsedLog.php?id=34166531&tree=Thunderbird-Trunk
TB Windows 7 32-bit comm-central opt test mozmill on 2014-02-05 14:47:32
revision: 87a9d2b23012
slave: t-w732-ix-061

TEST-UNEXPECTED-FAIL | C:\slave\test\build\mozmill\message-header\test-message-header.js | test-message-header.js::test_a11y_attrs
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run

Comment 5

[Legacy TBPL/Treeherder Robot]

RyanVM
https://tbpl.mozilla.org/php/getParsedLog.php?id=34205468&tree=Thunderbird-Trunk
TB Windows 7 32-bit comm-central opt test mozmill on 2014-02-06 04:07:27
revision: 2e4699e14f86
slave: t-w732-ix-021

TEST-UNEXPECTED-FAIL | C:\slave\test\build\mozmill\message-header\test-message-header.js | test-message-header.js::test_a11y_attrs
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run

Comment 6

[Legacy TBPL/Treeherder Robot]

RyanVM
https://tbpl.mozilla.org/php/getParsedLog.php?id=34280917&tree=Thunderbird-Trunk
TB Windows 7 32-bit comm-central opt test mozmill on 2014-02-07 04:29:16
revision: 2e4699e14f86
slave: t-w732-ix-014

TEST-UNEXPECTED-FAIL | C:\slave\test\build\mozmill\message-header\test-message-header.js | test-message-header.js::test_a11y_attrs
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run

Comment 7

[Legacy TBPL/Treeherder Robot]

RyanVM
https://tbpl.mozilla.org/php/getParsedLog.php?id=34293132&tree=Thunderbird-Trunk
TB Windows 7 32-bit comm-central opt test mozmill on 2014-02-07 08:38:31
revision: 9b9111e72080
slave: t-w732-ix-056

TEST-UNEXPECTED-FAIL | C:\slave\test\build\mozmill\message-header\test-message-header.js | test-message-header.js::test_a11y_attrs
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run

Comment 8

[Legacy TBPL/Treeherder Robot]

RyanVM
https://tbpl.mozilla.org/php/getParsedLog.php?id=34297735&tree=Thunderbird-Trunk
TB Windows XP 32-bit comm-central debug test mozmill on 2014-02-07 09:17:47
revision: 24185a50213f
slave: t-xp32-ix-044

TEST-UNEXPECTED-FAIL | C:\slave\test\build\mozmill\message-header\test-message-header.js | test-message-header.js::test_a11y_attrs
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run

Comment 9

[Legacy TBPL/Treeherder Robot]

RyanVM
https://tbpl.mozilla.org/php/getParsedLog.php?id=34388963&tree=Thunderbird-Trunk
Ubuntu VM 12.04 comm-central opt test mozmill on 2014-02-09 14:37:14
revision: c7fc213e0bcf
slave: tst-linux32-spot-171

TEST-UNEXPECTED-FAIL | /builds/slave/test/build/mozmill/message-header/test-message-header.js | test-message-header.js::test_a11y_attrs
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run

Comment 10

[Legacy TBPL/Treeherder Robot]

RyanVM
https://tbpl.mozilla.org/php/getParsedLog.php?id=34341974&tree=Thunderbird-Trunk
Ubuntu VM 12.04 comm-central debug test mozmill on 2014-02-08 02:06:24
revision: d55033527ee3
slave: tst-linux32-spot-141

TEST-UNEXPECTED-FAIL | /builds/slave/test/build/mozmill/message-header/test-message-header.js | test-message-header.js::test_a11y_attrs
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/mozmill/newmailaccount/test-newmailaccount.js | test-newmailaccount.js::test_show_tos_privacy_links_for_selected_providers
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run

Comment 11

[Legacy TBPL/Treeherder Robot]

RyanVM
https://tbpl.mozilla.org/php/getParsedLog.php?id=34423395&tree=Thunderbird-Trunk
TB Windows 7 32-bit comm-central opt test mozmill on 2014-02-10 07:37:16
revision: 3edad2919f73
slave: t-w732-ix-054

TEST-UNEXPECTED-FAIL | C:\slave\test\build\mozmill\message-header\test-message-header.js | test-message-header.js::test_a11y_attrs
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run

Comment 12

[Neil Deakin]

Attachment: accesskeycontrol

Setting labelElement should happen even when no accesskey is set.

Mark, as I can't seem to build Thunderbird right now, could you verify if this fixes the failure?

Comment 13

[Legacy TBPL/Treeherder Robot]

RyanVM
https://tbpl.mozilla.org/php/getParsedLog.php?id=34483203&tree=Thunderbird-Trunk
TB Windows 7 32-bit comm-central opt test mozmill on 2014-02-11 04:36:14
revision: 3edad2919f73
slave: t-w732-ix-104

TEST-UNEXPECTED-FAIL | C:\slave\test\build\mozmill\message-header\test-message-header.js | test-message-header.js::test_a11y_attrs
TEST-UNEXPECTED-FAIL | (runtestlist.py) | Exited with code 1 during directory run

Comment 14

[:aceman]

We attempted a try run with this patch at https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=360adfeb091b . Hopefully the /toolkit patch got applied there (on c-c), but the failing test now passed.

Comment 15

[Mark Banner (:standard8)]

Comment on attachment 8373516 [details] [diff] [review]
accesskeycontrol

Just to confirm, the patch applied fine on try server.

Thanks for fixing this.

Comment 16

[Neil Deakin]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ad74d750e5a5

Comment 17

[Neil Deakin]

Comment on attachment 8373516 [details] [diff] [review]
accesskeycontrol

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 963105
User impact if declined: fixes regression where textbox labels won't be available to accessibility 
Testing completed (on m-c, etc.): yes, passes on try server, tested by thunderbird folks
Risk to taking this patch (and alternatives if risky): none, only restores code that should have been executing, no new code
String or IDL/UUID changes made by this patch: none

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ad74d750e5a5

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/88d9611b1529