Closed Bug 967442 Opened 10 years ago Closed 10 years ago

Don't enlarge the opposite axis when skating along an axis

Categories

(Core :: Panning and Zooming, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: drs, Assigned: drs)

Details

Attachments

(1 file)

Currently, when skating, we're enlarging the displayport along the skating axis by its skating multiplier and the opposite axis by its stationary multiplier. To improve paint times, we can avoid enlarging the opposite axis at all.
I don't think this will actually noticeably improve performance in B2G apps since they're usually constrained along x to device-width anyways, so they paint the same amount on this axis with or without this patch. I'm not going to nom this for B2G 1.3.
Assignee: nobody → bugzilla
Attachment #8369987 - Flags: review?(botond)
Comment on attachment 8369987 [details] [diff] [review]
Don't enlarge the opposite axis when skating along an axis

Review of attachment 8369987 [details] [diff] [review]:
-----------------------------------------------------------------

Drive-by:
(1) I'd like to see this behaviour pref-controlled (and disabled by default) so we can experiment with it. There is a potential to regress stuff here, particularly on Metro, and so if we want it on B2G we should pref it on there explicitly.
(2) This seems better to have if axis-locking is enabled. If axis locking is disabled, it's very easy to start skating on the cross-axis which will (with this patch) result in checkerboarding on that axis because there's no margins at all. Of course this won't happen in Gaia apps because but will in the browser. Again, if this is pref-controlled we can make sure it's preffed the same as axis-locking.
(3) Please generate your patches with -U8 for more context lines.
Comment on attachment 8369987 [details] [diff] [review]
Don't enlarge the opposite axis when skating along an axis

Review of attachment 8369987 [details] [diff] [review]:
-----------------------------------------------------------------

Code looks good, but let's pref this like Kats said. Minusing for now.
Attachment #8369987 - Flags: review?(botond) → review-
I'm clearing the blocks list. This is not necessary for 1.3, and I can resolve conflicts manually on the other patches since nothing is actually directly depended on in here.
No longer blocks: 942750, 967449
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: