967454 - [System Browser] Offline errors render without a close button in system browser content

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Description

[Jason Smith [:jsmith]]

Attachment: BrowserOfflineError.png

Build:

* Build ID: 20140203040201
* Version: 1.4

STR

1. Without a network connection, open the rocketbar and search a term

Expected

I should see an offline error with a close button present.

Actual

I end up with an offline error without a close button present.

Comment 1

[Jason Smith [:jsmith]]

Regression from moving from the standalone browser app to the system browser app.

Comment 2

[Jason Smith [:jsmith]]

(In reply to Jason Smith [:jsmith] from comment #1)
> Regression from moving from the standalone browser app to the system browser
> app.

Let's actually call this needed for parity, rather than a regression.

Comment 3

[Jason Smith [:jsmith]]

Clearing nom - system browser is a targeted feature, not committed, so we won't start blocking on this until we've confirmed that we're feature complete for this feature.

Comment 4

[Kevin Grandon :kgrandon]

The network error page has been redesigned since then I believe. An image of the new network error and can be found in bug 1047682, this attachment: https://bug1047682.bugzilla.mozilla.org/attachment.cgi?id=8466505

Mike - let me know if this is wrong, thanks!

Comment 5

[Michael Henretty [:mikehenrty][:mhenretty]]

Yup, I think this is indeed WORKSFORME