967572 - DevTools Light theme text input border is a bit dark

Status: VERIFIED FIXED

(DevTools :: General, defect)

Description

[Brian Grinstead [:bgrins]]

Attachment: text-input-border.png

See attached screenshot.  It should be lighter

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: theme-search-border.patch

Splits out the border color as a setting per theme

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: text-input-border-updated.png

Screenshot with patch applied

Comment 3

[Victor Porof [:vporof][:vp]]

Comment on attachment 8370124 [details] [diff] [review]
theme-search-border.patch

Review of attachment 8370124 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/shared/devtools/toolbars.inc.css
@@ +213,5 @@
>  }
>  
> +.theme-dark .devtools-textinput,
> +.theme-dark .devtools-searchinput {
> +  border-color: rgb(88, 94, 101);

Where is this color coming from? Should we use a color from the palette instead? If so, please document it as well.

Comment 4

[Brian Grinstead [:bgrins]]

(In reply to Victor Porof [:vp] from comment #3)
> Comment on attachment 8370124 [details] [diff] [review]
> theme-search-border.patch
> 
> Review of attachment 8370124 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: browser/themes/shared/devtools/toolbars.inc.css
> @@ +213,5 @@
> >  }
> >  
> > +.theme-dark .devtools-textinput,
> > +.theme-dark .devtools-searchinput {
> > +  border-color: rgb(88, 94, 101);
> 
> Where is this color coming from? Should we use a color from the palette
> instead? If so, please document it as well.

I showed screenshots to Darrin with both the current color, compared with the corresponding dark theme color (black in this case), and he preferred to just stick with what was already there.

Comment 5

[Victor Porof [:vporof][:vp]]

ok!

Comment 6

[Brian Grinstead [:bgrins]]

 https://hg.mozilla.org/integration/fx-team/rev/da727ba3a9fa
https://tbpl.mozilla.org/?tree=Fx-Team&rev=da727ba3a9fa

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/da727ba3a9fa

Comment 8

[Brian Grinstead [:bgrins]]

Comment on attachment 8370124 [details] [diff] [review]
theme-search-border.patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 957117
User impact if declined: Contrast between search input and toolbars in DevTools light theme will be too high
Testing completed (on m-c, etc.): On m-c since 2-06
Risk to taking this patch (and alternatives if risky): Low risk change - CSS update to DevTools only
String or IDL/UUID changes made by this patch:

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b476e04bbf91

Comment 10

[Tracy Walker [:tracy]]

Verified with latest builds of Nightly and Aurora