Closed
Bug 967576
Opened 11 years ago
Closed 9 years ago
Upgrade to awesome-slugify in the Marketplace
Categories
(Marketplace Graveyard :: Code Quality, defect, P5)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: clouserw, Unassigned)
References
Details
(Whiteboard: [marketplace-transition])
From https://groups.google.com/forum/#!topic/mozilla.dev.webdev/wUnwYn6BNpY :
If you haven't already done so, consider replacing the built-in django
slugify function with https://github.com/dimka665/awesome-slugify
I just installed this on airmozilla
https://github.com/mozilla/airmozilla/commit/1cbdc26e2fb093f2748a35db31f7b90add17de2d
You can read more about it here:
http://pydanny.com/awesome-slugify-human-readable-url-slugs-from-any-string.html
with this cool example:
>>> import slugify
>>> slugify.slugify(u"straße") # Yet again the German for road
u'strasse'
A noticeable difference compared to from
django.template.defaultfilters.slugify is that awesome-slugify does not,
by default, make the slug lowercase.
Updated•11 years ago
|
Whiteboard: [contribute]
Updated•11 years ago
|
Component: General → Code Quality
Reporter | ||
Updated•11 years ago
|
Whiteboard: [contribute] → [good first bug]
Comment 2•10 years ago
|
||
Hi Kevin/MP-Team, it looks like this might not be very much clear to the newbie how to fix this. Can you put some information here for newbies so that they can pick this bug and fix it.
Thanks,
Ram
Flags: needinfo?(kngo)
Comment 3•10 years ago
|
||
I don't recommend Django bugs for good first bugs.
Flags: needinfo?(kngo)
Whiteboard: [good first bug]
Comment 4•10 years ago
|
||
I think Django can be fine for good first bugs. Awesome slugify is here:
https://pypi.python.org/pypi/awesome-slugify
What more information does someone need?
Whiteboard: [good first bug]
Comment 5•10 years ago
|
||
To be realistic, our current contributors are heavily CSS with a bit of JS. It might be easy for us, but marking this good first bug would only be distracting for our current community.
Whiteboard: [good first bug]
Comment 6•10 years ago
|
||
We're planning to establish contribution skill levels with Amy. We should keep things like this in mind for that discussion.
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
Whiteboard: [marketplace-transition]
You need to log in
before you can comment on or make changes to this bug.
Description
•