Closed Bug 967583 Opened 7 years ago Closed 7 years ago

Tooltip for 'Get Mail for' button says 'nobody' for Local Folders, Feed and News accounts, sometimes ends with comma

Categories

(Thunderbird :: Toolbars and Tabs, defect)

Product:
Thunderbird
Component:
Toolbars and Tabs
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 33.0

People

(Reporter: aryx, Assigned: aryx)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

patch, v3, ui+r=bwinton
1.70 KB, patch
Details | Diff | Splinter Review 
Thunderbird 30.0a1 20140204030201 on Windows 8.1 Pro 64 bit

Bug 516354 added the account name to the tooltip of the Get Mail button. There are issues with that:

If only the account's root folder has been selected in the folder pane:
- Local Folders and Feeds shown as 'nobody'
- News shown as empty string

So selecting folders from multiple accounts will e.g. show for Feeds and Local Folders "Get new messages for nobody, "
Blocks: 516354
Keywords: regression
OS: Windows 8.1 → All
Hardware: x86_64 → All
Attached patch patch, v1 (obsolete) — — Splinter Review 
One-line change.
Assignee: nobody → archaeopteryx
Status: NEW → ASSIGNED
Attachment #8413391 - Flags: review?(bwinton)
Comment on attachment 8413391 [details] [diff] [review]
patch, v1

So, the code seems mostly fine, except the variable name is now a lie!  ;)
r=me if you change it to "names", and "namesArray", and "tooltipNames".
Attachment #8413391 - Flags: ui-review+
Attachment #8413391 - Flags: review?(bwinton)
Attachment #8413391 - Flags: review+
https://hg.mozilla.org/comm-central/rev/80606aaa27d2
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 33.0
Blocks: 1022209
You need to log in before you can comment on or make changes to this bug.