967583 - Tooltip for 'Get Mail for' button says 'nobody' for Local Folders, Feed and News accounts, sometimes ends with comma

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Thunderbird 30.0a1 20140204030201 on Windows 8.1 Pro 64 bit

Bug 516354 added the account name to the tooltip of the Get Mail button. There are issues with that:

If only the account's root folder has been selected in the folder pane:
- Local Folders and Feeds shown as 'nobody'
- News shown as empty string

So selecting folders from multiple accounts will e.g. show for Feeds and Local Folders "Get new messages for nobody, "

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: patch, v1

One-line change.

Comment 2

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 8413391 [details] [diff] [review]
patch, v1

So, the code seems mostly fine, except the variable name is now a lie!  ;)
r=me if you change it to "names", and "namesArray", and "tooltipNames".

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: patch, v3, ui+r=bwinton

Comment 4

[Mark Banner (:standard8) (afk until 8th Aug)]

https://hg.mozilla.org/comm-central/rev/80606aaa27d2