Enable baseline compilation for with statements

RESOLVED FIXED in mozilla30

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: wingo, Assigned: wingo)

Tracking

unspecified
mozilla30
x86
macOS
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

5 years ago
With is bad, but this patch is small, so...
Assignee

Updated

5 years ago
Assignee: nobody → wingo
Assignee

Comment 2

5 years ago
Comment on attachment 8370169 [details] [diff] [review]
Enable baseline compilation for with statements

Depends on bug 966912, which is ready to check in once the tree opens.
Attachment #8370169 - Flags: review?(jdemooij)
Comment on attachment 8370169 [details] [diff] [review]
Enable baseline compilation for with statements

Review of attachment 8370169 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!

::: js/src/jit/VMFunctions.cpp
@@ +933,5 @@
>  
>  bool
> +EnterWith(JSContext *cx, BaselineFrame *frame, HandleValue val, Handle<StaticWithObject *> templ)
> +{
> +    RootedObject obj(cx);

Can you rename the EnterWith in Interpreter.cpp to EnterWithOperation (see also DefFunOperation, ImplicitThisOperation, etc) and do:

return EnterWithOperation(cx, frame, val, templ);

here? It's not a lot of code but it'd be nice to share it with the interpreter.
Attachment #8370169 - Flags: review?(jdemooij) → review+
Assignee

Comment 4

5 years ago
Fixed nit as you suggested.

https://hg.mozilla.org/integration/mozilla-inbound/rev/e869145b20d0
Flags: in-testsuite+
https://hg.mozilla.org/mozilla-central/rev/e869145b20d0
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.