967649 - Enable baseline compilation for with statements

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Andy Wingo [:wingo]]

With is bad, but this patch is small, so...

Comment 1

[Andy Wingo [:wingo]]

Attachment: Enable baseline compilation for with statements

Comment 2

[Andy Wingo [:wingo]]

Comment on attachment 8370169 [details] [diff] [review]
Enable baseline compilation for with statements

Depends on bug 966912, which is ready to check in once the tree opens.

Comment 3

[Jan de Mooij [:jandem]]

Comment on attachment 8370169 [details] [diff] [review]
Enable baseline compilation for with statements

Review of attachment 8370169 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!

::: js/src/jit/VMFunctions.cpp
@@ +933,5 @@
>  
>  bool
> +EnterWith(JSContext *cx, BaselineFrame *frame, HandleValue val, Handle<StaticWithObject *> templ)
> +{
> +    RootedObject obj(cx);

Can you rename the EnterWith in Interpreter.cpp to EnterWithOperation (see also DefFunOperation, ImplicitThisOperation, etc) and do:

return EnterWithOperation(cx, frame, val, templ);

here? It's not a lot of code but it'd be nice to share it with the interpreter.

Comment 4

[Andy Wingo [:wingo]]

Fixed nit as you suggested.

https://hg.mozilla.org/integration/mozilla-inbound/rev/e869145b20d0

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e869145b20d0