Closed Bug 967698 Opened 8 years ago Closed 8 years ago

Update acorn to latest version

Categories

(DevTools :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 30

People

(Reporter: bbenvie, Assigned: bbenvie)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file, 1 obsolete file)

Recent versions of acorn began exporting a couple useful functions (isIdentifierStart, isIdentifierChar). These are used by the tern CodeMirror plugin.
Blocks: 967813
Attachment #8370232 - Flags: review?(nfitzgerald)
I guess this will need a sec review as well.
Whiteboard: [sec-review]
Comment on attachment 8370232 [details] [diff] [review]
update-acorn.patch

Review of attachment 8370232 [details] [diff] [review]:
-----------------------------------------------------------------

What am I supposed to do with this? The diff is literally everything on both and I just don't know what proper protocol is in this situation. Do we need a new secreview? Should I look at the whole file again? Do we just wait for a green try?
Attachment #8370232 - Flags: review?(nfitzgerald)
Yeah I was trying to figure out why the diff wouldn't come out more piecemeal. It's like it just gives up if there's too many changes. We're actually upgrading pretty far, from 0.1.01 to 0.4. I'll try and get a more useful diff.
Here's a better diff.
Assignee: nobody → bbenvie
Attachment #8370232 - Attachment is obsolete: true
Status: NEW → ASSIGNED
On second look, I don't think this needs a sec-review.
Whiteboard: [sec-review]
https://hg.mozilla.org/mozilla-central/rev/4062ef4ec9c5
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 30
Whiteboard: [qa-]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.