Closed
Bug 967883
Opened 12 years ago
Closed 12 years ago
modify_keywords() shouldn't throw an error when an unprivileged user doesn't alter the keywords list
Categories
(Bugzilla :: Creating/Changing Bugs, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 4.4
People
(Reporter: mail, Assigned: LpSolit)
Details
Attachments
(1 file)
|
3.34 KB,
patch
|
gerv
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:26.0) Gecko/20100101 Firefox/26.0 (Beta/Release)
Build ID: 20140120095152
Steps to reproduce:
1) A user without the editbugs privilege views a bug, and adds a comment.
2) The bug already has the 'Security' keyword already set.
3) When updating the bug, some extension code calls
$bug->modify_keywords('Security', 'add');
Actual results:
Error message: "You tried to change the Keywords field from Security to Security , but only the assignee or reporter of the bug, or a user with the required permissions may change that field."
Expected results:
Since no actual change was being made, there should be no error.
Whether the fault is with modify_keywords or check_can_change_field is for the bug fixer to decide.
|
Assignee | |
Updated•12 years ago
|
Summary: Bugzilla complains about a field not changing → modify_keywords() shouldn't throw an error when an unprivileged user doesn't alter the keywords list
Target Milestone: --- → Bugzilla 4.4
|
|
Assignee | |
Comment 1•12 years ago
|
||
Assignee: create-and-change → LpSolit
Status: NEW → ASSIGNED
Attachment #8370744 -
Flags: review?(glob)
|
|
Assignee | |
Updated•12 years ago
|
Severity: normal → minor
|
|
Assignee | |
Updated•12 years ago
|
Attachment #8370744 -
Flags: review?(glob) → review?(gerv)
|
|
||
Comment 2•12 years ago
|
||
Comment on attachment 8370744 [details] [diff] [review]
patch, v1
r=gerv.
Gerv
Attachment #8370744 -
Flags: review?(gerv) → review+
|
|
Assignee | |
Updated•12 years ago
|
Flags: approval?
Flags: approval4.4?
|
||
Updated•12 years ago
|
Flags: approval?
Flags: approval4.4?
Flags: approval4.4+
Flags: approval+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/Bug.pm
modified template/en/default/global/user-error.html.tmpl
Committed revision 8928.
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.4/
modified Bugzilla/Bug.pm
modified template/en/default/global/user-error.html.tmpl
Committed revision 8660.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•