967928 - TSan: data race js/src/../../js/src/jit/IonCaches.h:217 canAttachStub

Status: RESOLVED INVALID

(Core :: JavaScript Engine, defect)

Description

[Christian Holler (:decoder)]

Attachment: Logfile with TSan trace

The attached logfile shows a thread/data race (mozilla-central revision 44ba69cacd7e) detected by TSan (ThreadSanitizer).

Typically, races reported by TSan are not false positives, but it is possible that the race is benign. Even in this case though, we should try to come up with a fix unless this would cause inacceptable performance issues. Also note that seemingly benign races can possibly be harmful (also depending on the compiler and the architecture) [1].

If the bug cannot be fixed, then this bug should be used to either make a compile-time annotation for blacklisting or add an entry to the runtime blacklist.

[1] http://software.intel.com/en-us/blogs/2013/01/06/benign-data-races-what-could-possibly-go-wrong

Comment 1

[Jan de Mooij [:jandem]]

This looks like a PJS Ion IC race.

Comment 2

[Nicolas B. Pierron [:nbp]]

This is a known race, and it has been addressed during the review process.
We paid attention at keeping this race aligned on a cache line and we should have assertions about it.

Comment 3

[Jan de Mooij [:jandem]]

PJS is gone.