Closed Bug 967929 Opened 10 years ago Closed 10 years ago

Remove nsSupportsHashtable

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla30

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file, 1 obsolete file)

Remove nsSupportsHashtable.
5.05 KB, patch
benjamin
: review+
Details | Diff | Splinter Review 
This is deprecated, and there are only 3 uses of it (the various XBL forward declarations are bogus), so it shouldn't be too hard to get rid of it.
Depends on: 967931
Depends on: 967941
Depends on: 967999
Depends on: 968012
Blocks: 971264
Attached patch Remove nsSupportsHashtable. (obsolete) — — Splinter Review 

    
  
Assignee: nobody → continuation

    
    

    
  


  
https://tbpl.mozilla.org/?tree=Try&rev=919977e5c90b

        Attachment #8375849 -
        Attachment is obsolete: true

        Attachment #8379775 -
        Flags: superreview?(benjamin)

        Attachment #8379775 -
        Flags: review?(nfroyd)

    
    

    
  
Comment on attachment 8379775 [details] [diff] [review]
Remove nsSupportsHashtable.

I guess it is overkill for this simple patch to have a reviewer and a super reviewer...

        Attachment #8379775 -
        Flags: superreview?(benjamin)

        Attachment #8379775 -
        Flags: review?(nfroyd)

        Attachment #8379775 -
        Flags: review?(benjamin)

    
  

        Attachment #8379775 -
        Flags: review?(benjamin) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/3b32d0f94b57
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30

    
    

    
  
In case anybody is curious, here's the commit from 1999 that added nsSupportsHashtable (and nsObjectHashtable):
    https://github.com/mozilla/gecko-dev/commit/d3f90ec7553f4943b927a4931b12c54ffe77eaba

    
    

    
  
I removed the brief reference to nsSupportsHashtable from the Detailed XPCOM hashtable guide.
Keywords: dev-doc-complete

          You need to log in
          before you can comment on or make changes to this bug.