Closed Bug 968023 Opened 6 years ago Closed 6 years ago

Remove nsISimpleEnumerator from import thread

Categories

(MailNews Core :: Import, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 30.0

People

(Reporter: hiro, Assigned: hiro)

References

Details

Attachments

(1 file)

otherwise thunderbird debug build causes a crash:

Hit MOZ_CRASH(nsCOMArrayEnumerator not thread-safe) at /home/zoe/hg/comm-central/mozilla/xpcom/glue/nsArrayEnumerator.cpp:128
Attached patch bug968023.patchSplinter Review
Assignee: nobody → hiikezoe
Status: NEW → ASSIGNED
Attachment #8370543 - Flags: review?(neil)
Blocks: 684455
Comment on attachment 8370543 [details] [diff] [review]
bug968023.patch

> NS_IMETHODIMP GetSubFoldersRunnable::Run()
> {
>-  return m_folder->GetSubFolders(m_enumerator);
>+  return m_folder->GetSubFolders(nullptr);
This confused me briefly until I noticed that passing nullptr is an existing pattern here (normally that's not allowed for XPCOM out parameters).
Attachment #8370543 - Flags: review?(neil) → review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/22a4aeca5215
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 30.0
You need to log in before you can comment on or make changes to this bug.