Use unprefixed box-sizing internally

RESOLVED FIXED in mozilla30

Status

()

Core
Layout
--
minor
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Alex Henrie, Assigned: Alex Henrie)

Tracking

Trunk
mozilla30
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments, 2 obsolete attachments)

(Assignee)

Description

3 years ago
All instances of -moz-box-sizing, -webkit-box-sizing, and -ms-box-sizing in the Mozilla codebase should be converted to the standard property box-sizing. WebKit and Trident dropped their prefixes long ago, and Gecko has recently done the same.

See:
https://bugzilla.mozilla.org/show_bug.cgi?id=243412#c107
https://bugzilla.mozilla.org/show_bug.cgi?id=243412#c118
(Assignee)

Comment 1

3 years ago
Created attachment 8370554 [details] [diff] [review]
Use unprefixed box-sizing in browser/extensions/pdfjs/
Attachment #8370554 - Flags: review?(bdahl)
(Assignee)

Comment 2

3 years ago
Created attachment 8370555 [details] [diff] [review]
Use unprefixed box-sizing in browser/ and toolkit/
Attachment #8370555 - Flags: review?(gavin.sharp)
(Assignee)

Comment 3

3 years ago
Created attachment 8370556 [details] [diff] [review]
Use unprefixed box-sizing in mobile/android/
Attachment #8370556 - Flags: review?(mark.finkle)
Attachment #8370556 - Flags: review?(margaret.leibovic)
(Assignee)

Comment 4

3 years ago
Created attachment 8370557 [details] [diff] [review]
Use unprefixed box-sizing in content/, dom/, layout/, and widget/
Attachment #8370557 - Flags: review?(dbaron)
(Assignee)

Comment 5

3 years ago
https://tbpl.mozilla.org/?tree=Try&rev=04d79930a29c
Comment on attachment 8370556 [details] [diff] [review]
Use unprefixed box-sizing in mobile/android/

Looks fine. I didn't see any JS uses.
(also, saving margaret the review)
Attachment #8370556 - Flags: review?(mark.finkle)
Attachment #8370556 - Flags: review?(margaret.leibovic)
Attachment #8370556 - Flags: review+
Comment on attachment 8370557 [details] [diff] [review]
Use unprefixed box-sizing in content/, dom/, layout/, and widget/

r=dbaron

... although I already landed the parts in layout/reftests/w3c-css/submitted/ui3/  in https://hg.mozilla.org/integration/mozilla-inbound/rev/13f6dad08f3a , so those will need to be taken out of the patch


Also, one of us should (as a follow up) look into the tests that are using 'content' and 'padding' and 'border' (without the "-box") as values.  We used to support that a long time ago, and it seems likely that we should update the tests... assuming they still pass with the fix.
Attachment #8370557 - Flags: review?(dbaron) → review+

Updated

3 years ago
Attachment #8370555 - Flags: review?(gavin.sharp) → review+
Comment on attachment 8370554 [details] [diff] [review]
Use unprefixed box-sizing in browser/extensions/pdfjs/

Review of attachment 8370554 [details] [diff] [review]:
-----------------------------------------------------------------

This also needs to make it upstream to https://github.com/mozilla/pdf.js/blob/master/web/viewer.css#L922.
Attachment #8370554 - Flags: review?(bdahl) → review+
The CSS in aboutaccounts was imported from Web CSS, which explains the weird prefixes. Seems like we should probably also get rid of these there...

Updated

3 years ago
Assignee: nobody → alexhenrie24
(Assignee)

Comment 10

3 years ago
Created attachment 8371705 [details] [diff] [review]
Use unprefixed box-sizing in browser/extensions/pdfjs/

Rebased for checkin
Attachment #8370554 - Attachment is obsolete: true
Attachment #8371705 - Flags: review+
(Assignee)

Comment 11

3 years ago
Created attachment 8371706 [details] [diff] [review]
Use unprefixed box-sizing in content/, dom/, layout/, and widget/

Rebased for checkin
Attachment #8370557 - Attachment is obsolete: true
Attachment #8371706 - Flags: review+
(Assignee)

Updated

3 years ago
Attachment #8371706 - Attachment description: patch4 → Use unprefixed box-sizing in content/, dom/, layout/, and widget/
(Assignee)

Comment 12

3 years ago
Requesting checkin of all 4 attached patches. Note that the third patch should be r=bdahl and the fourth patch should be r=dbaron.
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/6960aec45b20
https://hg.mozilla.org/integration/mozilla-inbound/rev/8b95c9499474
https://hg.mozilla.org/integration/mozilla-inbound/rev/36459508cdac
https://hg.mozilla.org/integration/mozilla-inbound/rev/be8ad29ffc69

Please don't forget to get the pdf.js changes upstreamed so we don't accidentally revert them the next time we're syncing the in-tree copy with upstream.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/6960aec45b20
https://hg.mozilla.org/mozilla-central/rev/8b95c9499474
https://hg.mozilla.org/mozilla-central/rev/36459508cdac
https://hg.mozilla.org/mozilla-central/rev/be8ad29ffc69
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30

Updated

3 years ago
Blocks: 970475
You need to log in before you can comment on or make changes to this bug.