968075 - Make it possible to have a twig which does l10n nightlies, but does not trigger them based on l10n changes

Status: RESOLVED INVALID

(Release Engineering :: General, defect)

Description

[Mike Hommey [:glandium]]

While this is rare on mozilla-central (although it might have happened during the holidays), that can happen on disposable branches (for those that do run those periodic builds). For m-c there might be issues in hiding (like the handling of updates) so it might not be worth bothering for it, but for other branches (mostly disposable branches), that would avoid wasting resources.

Comment 1

[Phil Ringnalda (:philor)]

Bug 964071 fixed your multiple PGO and non-unified, that's why https://tbpl.mozilla.org/?tree=Birch&rev=19adee4bbced only has multiple nightlies. And it has multiple nightlies because you have l10n nightlies, and if you have l10n nightlies then you get another one if there have been no code changes but there have been l10n changes - you're getting those as a way for the Birch localizers to get a new nightly so they can see the effects of their changes even during periods when there haven't been any patches which got approval-birch. So the net remaining thing for this bug to be about is "make it possible to have a twig which does l10n nightlies, but doesn't care whether there have been l10n changes."

Comment 2

[Chris AtLee [:catlee]]

(In reply to Phil Ringnalda (:philor) from comment #1)
> Bug 964071 fixed your multiple PGO and non-unified, that's why
> https://tbpl.mozilla.org/?tree=Birch&rev=19adee4bbced only has multiple
> nightlies. And it has multiple nightlies because you have l10n nightlies,
> and if you have l10n nightlies then you get another one if there have been
> no code changes but there have been l10n changes - you're getting those as a
> way for the Birch localizers to get a new nightly so they can see the
> effects of their changes even during periods when there haven't been any
> patches which got approval-birch. So the net remaining thing for this bug to
> be about is "make it possible to have a twig which does l10n nightlies, but
> doesn't care whether there have been l10n changes."

I don't think you really want that. If you have l10n nightlies, then you want new nightlies when the upstream l10n repos change.

Comment 3

[Phil Ringnalda (:philor)]

Well, in this case he does, because he doesn't care what localizers do to l10n nightlies, only what he does to them. Birch doesn't have l10n nightlies so that localizers can see how their strings work on Birch, it has l10n nightlies so he can see whether his build changes break creating l10n nightlies.

Despite the general sound of comment 0 and the summary, this bug is really "https://tbpl.mozilla.org/?tree=Birch&rev=0e657b95b156 has gotten five nightlies so far, and I only want it to have gotten one".

Comment 4

[Ed Morley [:emorley]]

(Side note: not having this indirectly caused bug 991476)

Comment 5

[Phil Ringnalda (:philor)]

Not really, no. He had lastgood true at the time, from the default, his problem was l10n changes.

Comment 6

[Ed Morley [:emorley]]

Oh I read the original summary

Comment 7

[Ed Morley [:emorley]]

Filed bug 991707

Comment 8

[Justin Wood (:Callek)]

invalid - we no longer do onchnage-l10n so this bug is fixed by that alone