968081 - [B2G][L10n][Settings][Internet Sharing] Security field shows "wpa2-psk" by default, not loading translated strings

Status: RESOLVED FIXED

Description

[Peter Pin-Guang Chen [:petercpg] (MozTW.org)]

Steps to Reproduce:
1. Switch to English (US) locale
2. Go to Settings -> Internet Sharing, Security field shows "wpa2-psk"
3. Tap Hotspot settings, switch to other security protocols, tap OK
4. Security field shows "open" or "WPA (TKIP)"
5. Go to Hotspot settings again and switch to WPA2 (AES)
6. Security field now shows "WPA2 (AES)"

Expected Results: The initial security level should be the same to the option name, "WPA2 (AES)"

Actual Results: "wpa2-psk"


Device: Geeksphone Keon
Build: 20140205010019
Gaia: 3405205
Platform Version: 28.0

Comment 1

[Peter Pin-Guang Chen [:petercpg] (MozTW.org)]

Created attachment 8370603 [details]
2014-02-05-16-52-28.png

Comment 2

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Created attachment 8371136 [details] [review]
Pull Request #16010 - Localize WiFi hotspot security type string

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8371136 [details] [review]
Pull Request #16010 - Localize WiFi hotspot security type string

Thanks for the patch, Mihai!

The root cause of this issue is that we used `data-name="tethering.wifi.security.type"` and there is a very bad trick here. The trick is, we check whether the key specified with the data-name attribute is associated with a selector. If yes, we show the localization result instead of the value of the key. Please see [1] for the code. However, the selector of wifi security only exist after users navigate to the hotspot settings panel, that's why it fails.

I would suggest to remove the data-name attribute and use SettingsListener on "tethering.wifi.security.type" in hotspot.js, which is less magic and easier to trace. 

[1]: https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/settings.js#L509

Comment 4

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Comment on attachment 8371136 [details] [review]
Pull Request #16010 - Localize WiFi hotspot security type string

Thanks for the feedback, Arthur! Updated the PR with your suggestion, let me know if it looks good.

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8371136 [details] [review]
Pull Request #16010 - Localize WiFi hotspot security type string

r=me. Thanks!

Comment 6

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Thanks Arthur! Landed on master:
https://github.com/mozilla-b2g/gaia/commit/3f195048fb801620c9c294d3062ee9c9e7eacdba

Comment 7

[Wes Kocher (:KWierso)]

I had to revert this in https://github.com/mozilla-b2g/gaia/commit/0358dbe1b4b13a186f87d1fc5c8a8a29ab898a92 because it broke gaia unit tests on b2g-inbound: https://tbpl.mozilla.org/php/getParsedLog.php?id=34522345&tree=B2g-Inbound

Comment 8

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

That is weird, Travis was all green (https://travis-ci.org/mozilla-b2g/gaia/builds/18687931). Arthur, do you have any idea why the test failed on b2g-inbound?

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

Not sure how it got green in the first place. We should add the mock of SettingsListener in hotspot_test.js.

Comment 10

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Created attachment 8375172 [details] [review]
Pull Request #16232 - Localize WiFi hotspot security type string

Thanks Arthur, I updated the initial patch to use the mock for SettingsListener in the test, thus avoiding the failing unit test. Let me know if it is good.

Comment 11

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8375172 [details] [review]
Pull Request #16232 - Localize WiFi hotspot security type string

r=me. Thank you.

Comment 12

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Landed on master:
https://github.com/mozilla-b2g/gaia/commit/55c4094e5d5a44420b742e0959e961459dc6b1c4