968089 - [NFC] Cleanup nsNfc.js

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: NFC, defect)

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 968089: Cleanup nsNfc.js

This fixes the following errors reported by gjslint:

Line 7, E:0131: Single-quoted string preferred over double-quoted string.
Line 11, E:0131: Single-quoted string preferred over double-quoted string.
Line 11, E:0131: Single-quoted string preferred over double-quoted string.
Line 18, E:0131: Single-quoted string preferred over double-quoted string.
Line 19, E:0131: Single-quoted string preferred over double-quoted string.
Line 20, E:0131: Single-quoted string preferred over double-quoted string.
Line 23, E:0131: Single-quoted string preferred over double-quoted string.
Line 24, E:0131: Single-quoted string preferred over double-quoted string.
Line 25, E:0131: Single-quoted string preferred over double-quoted string.
Line 27, E:0001: Extra space after "NFC_PEER_EVENT_LOST"
Line 33, E:0131: Single-quoted string preferred over double-quoted string.
Line 34, E:0131: Single-quoted string preferred over double-quoted string.
Line 31, E:0225: Missing @this JsDoc in function referencing "this". (this usually means you are trying to reference "this" in a static function, or you have forgotten to mark a constructor with @constructor)
Line 63, E:0131: Single-quoted string preferred over double-quoted string.
Line 79, E:0110: Line too long (81 characters).
Line 86, E:0110: Line too long (85 characters).
Line 92, E:0131: Single-quoted string preferred over double-quoted string.
Line 93, E:0131: Single-quoted string preferred over double-quoted string.
Line 95, E:0121: Illegal comma at end of object literal
Line 102, E:0131: Single-quoted string preferred over double-quoted string.
Line 103, E:0131: Single-quoted string preferred over double-quoted string.
Line 100, E:0225: Missing @this JsDoc in function referencing "this". (this usually means you are trying to reference "this" in a static function, or you have forgotten to mark a constructor with @constructor)
Line 118, E:0131: Single-quoted string preferred over double-quoted string.
Line 127, E:0110: Line too long (81 characters).
Line 132, E:0131: Single-quoted string preferred over double-quoted string.
Line 139, E:0131: Single-quoted string preferred over double-quoted string.
Line 140, E:0131: Single-quoted string preferred over double-quoted string.
Line 142, E:0121: Illegal comma at end of object literal
Line 149, E:0131: Single-quoted string preferred over double-quoted string.
Line 151, E:0131: Single-quoted string preferred over double-quoted string.
Line 153, E:0002: Missing space before "("
Line 154, E:0131: Single-quoted string preferred over double-quoted string.
Line 154, E:0010: Missing semicolon at end of line
Line 147, E:0225: Missing @this JsDoc in function referencing "this". (this usually means you are trying to reference "this" in a static function, or you have forgotten to mark a constructor with @constructor)
Line 165, E:0131: Single-quoted string preferred over double-quoted string.
Line 195, E:0131: Single-quoted string preferred over double-quoted string.
Line 207, E:0131: Single-quoted string preferred over double-quoted string.
Line 214, E:0131: Single-quoted string preferred over double-quoted string.
Line 218, E:0131: Single-quoted string preferred over double-quoted string.
Line 223, E:0131: Single-quoted string preferred over double-quoted string.
Line 227, E:0131: Single-quoted string preferred over double-quoted string.
Line 276, E:0131: Single-quoted string preferred over double-quoted string.
Line 276, E:0131: Single-quoted string preferred over double-quoted string.
Line 278, E:0131: Single-quoted string preferred over double-quoted string.
Line 278, E:0002: Missing space after ":"
Line 284, E:0131: Single-quoted string preferred over double-quoted string.
Line 285, E:0131: Single-quoted string preferred over double-quoted string.
Line 287, E:0121: Illegal comma at end of object literal
Line 290, E:0110: Line too long (85 characters).

Comment 2

[[:fabrice] Fabrice Desré]

Comment on attachment 8370616 [details] [diff] [review]
[01] Bug 968089: Cleanup nsNfc.js

Review of attachment 8370616 [details] [diff] [review]:
-----------------------------------------------------------------

Changing all the quotes to single ones is not something I like a lot. Not sure if we have something about that in the code style, but that messes up the blame for no good reason.