968090 - Flatfish build fail due to Navigator::HasWifiManagerSupport error

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Wifi, defect)

Description

[Henry Chang [:hchang]]

Error message:

In file included from UnifiedBindings17.cpp:134:0:
MozWifiP2pManagerBinding.cpp: In function 'bool mozilla::dom::MozWifiP2pGroupOwnerBinding::ConstructorEnabled(JSContext*, JS::Handle<JSObject*>)':
MozWifiP2pManagerBinding.cpp:707:10: error: 'HasWifiManagerSupport' is not a member of 'mozilla::dom::Navigator'
In file included from UnifiedBindings17.cpp:134:0:
MozWifiP2pManagerBinding.cpp: In function 'bool mozilla::dom::MozWifiP2pManagerBinding::ConstructorEnabled(JSContext*, JS::Handle<JSObject*>)':
MozWifiP2pManagerBinding.cpp:1950:10: error: 'HasWifiManagerSupport' is not a member of 'mozilla::dom::Navigator'
In file included from UnifiedBindings17.cpp:146:0:
MozWifiP2pStatusChangeEventBinding.cpp: In function 'bool mozilla::dom::MozWifiP2pStatusChangeEventBinding::ConstructorEnabled(JSContext*, JS::Handle<JSObject*>)':
MozWifiP2pStatusChangeEventBinding.cpp:394:10: error: 'HasWifiManagerSupport' is not a member of 'mozilla::dom::Navigator'

The root cause is Navigator::HasWifiManagerSupport should still present when MOZ_B2G_RIL is off.

Comment 1

[Henry Chang [:hchang]]

Attachment: bug968090.patch

Comment 2

[Danny Liang [:dliang]]

Henry, it can build successfully with your patch.

Comment 3

[Danny Liang [:dliang]]

(In reply to Henry Chang [:henry] from comment #1)
> Created attachment 8370615 [details] [diff] [review]
> bug968090.patch

Henry, could you invite reviewer to review your patch? The patch must be land on master to avoid build break of tablet device. Please let us know if any concern.

Comment 4

[Henry Chang [:hchang]]

(In reply to Danny Liang [:dliang] from comment #3)
> (In reply to Henry Chang [:henry] from comment #1)
> > Created attachment 8370615 [details] [diff] [review]
> > bug968090.patch
> 
> Henry, could you invite reviewer to review your patch? The patch must be
> land on master to avoid build break of tablet device. Please let us know if
> any concern.

Sure! I usually ask Vincent Chang for reviewing wifi related patches but he's on vacation.
If you need this patch landed by today, I could ask someone else to review instead.

Thanks.

Comment 5

[Henry Chang [:hchang]]

Comment on attachment 8370615 [details] [diff] [review]
bug968090.patch

Hi Gene, could you please help review this simple patch? It just put two functions out of MOZ_B2G_RIL to prevent from build fail when MOZ_B2G_RIL is not defined. Flatfish developers require this patch to fix the build error. Thanks.

Comment 6

[Gene Lian (I already quit Mozilla)]

Comment on attachment 8370615 [details] [diff] [review]
bug968090.patch

Review of attachment 8370615 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! Thank you!

Comment 7

[Henry Chang [:hchang]]

(In reply to Gene Lian [:gene] (needinfo? encouraged) from comment #6)
> Comment on attachment 8370615 [details] [diff] [review]
> bug968090.patch
> 
> Review of attachment 8370615 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Nice! Thank you!

Thanks! I am going to update the commit message and mark checkin-needed. Thanks

Comment 8

[Henry Chang [:hchang]]

Attachment: Patch to commit (r+'d, commit message updated)

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/ab5d617096f2

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ab5d617096f2