Wrong text at ng-reports section of the dashboard

VERIFIED FIXED

Status

Mozilla Reps
reps.mozilla.org
VERIFIED FIXED
4 years ago
3 years ago

People

(Reporter: nemo, Assigned: xiaodi.yu, Mentored)

Tracking

Details

(Whiteboard: [kb=1493338] [good first bug][lang=python])

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Created attachment 8370620 [details]
dashboard-reports-text.png

When there is only one activity in the new reports dashboard the text displayed is wrong. It should be changed to "1 Activity" instead of "1 Activities".
(Reporter)

Updated

4 years ago
Group: mozilla-reps-admins
(Reporter)

Updated

4 years ago
Whiteboard: [good first bug][lang=python][mentor=jgiannelos@mozilla.com]
(Reporter)

Updated

4 years ago
Whiteboard: [good first bug][lang=python][mentor=jgiannelos@mozilla.com] → [kb=1263086] [good first bug][lang=python][mentor=jgiannelos@mozilla.com]
OS: Linux → All
Hardware: x86_64 → All

Comment 1

4 years ago
I would like to work on this bug, Can someone assign it to me?
(Reporter)

Comment 2

4 years ago
Hi dweep. I am assigning this bug to you.

If you have any questions about the bug feel free to ping me
here or in #remo-dev IRC channel.
(Reporter)

Updated

4 years ago
Assignee: nobody → dweeprk

Comment 3

4 years ago
When I run the command ./manage.py syncdb && ./manage.py migrate.
It gives the following error
File "./manage.py", line 27, in <module>
    manage.main()
  File "/home/chitra/purana/Documents/remo/vendor/src/funfactory/funfactory/manage.py", line 143, in main
    execute_manager(current_settings)
  File "/home/chitra/purana/Documents/remo/vendor/lib/python/django/core/management/__init__.py", line 459, in execute_manager
    utility.execute()
  File "/home/chitra/purana/Documents/remo/vendor/lib/python/django/core/management/__init__.py", line 382, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/home/chitra/purana/Documents/remo/vendor/lib/python/django/core/management/__init__.py", line 261, in fetch_command
    klass = load_command_class(app_name, subcommand)
  File "/home/chitra/purana/Documents/remo/vendor/lib/python/django/core/management/__init__.py", line 69, in load_command_class
    module = import_module('%s.management.commands.%s' % (app_name, name))
  File "/home/chitra/purana/Documents/remo/vendor/lib/python/django/utils/importlib.py", line 35, in import_module
    __import__(name)
  File "/home/chitra/purana/Documents/remo/vendor-local/lib/python/south/management/commands/__init__.py", line 10, in <module>
    import django.template.loaders.app_directories
  File "/home/chitra/purana/Documents/remo/vendor/lib/python/django/template/loaders/app_directories.py", line 23, in <module>
    raise ImproperlyConfigured('ImportError %s: %s' % (app, e.args[0]))
django.core.exceptions.ImproperlyConfigured: ImportError tower: No module named jinja2
(Reporter)

Comment 4

4 years ago
Hey dweep,

This error is triggered because of the jinja2 module not being available.
Have you followed this instructions here [1]? Jinja2 is installed in step #4 using:

pip install -r requirements/dev.txt

Pip command might have exited with an error. Was there any traceback after that command?

Thanks!

[1]http://remo.readthedocs.org/en/latest/installation-virtualenv.html#build-the-environment
(Reporter)

Updated

4 years ago
Flags: needinfo?(dweeprk)

Comment 5

4 years ago
Hey john,
    When I run the command the following command
pip install -r requirements/dev.txt
I gives the following error
building 'lxml.etree' extension

gcc -pthread -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fPIC -I/home/chitra/purana/Documents/remo/remo/venv/build/lxml/src/lxml/includes -I/usr/include/python2.7 -c src/lxml/lxml.etree.c -o build/temp.linux-i686-2.7/src/lxml/lxml.etree.o -w

In file included from src/lxml/lxml.etree.c:346:0:

/home/chitra/purana/Documents/remo/remo/venv/build/lxml/src/lxml/includes/etree_defs.h:9:31: fatal error: libxml/xmlversion.h: No such file or directory

compilation terminated.

error: command 'gcc' failed with exit status 1

----------------------------------------
Command /home/chitra/purana/Documents/remo/remo/venv/bin/python -c "import setuptools;__file__='/home/chitra/purana/Documents/remo/remo/venv/build/lxml/setup.py';exec(compile(open(__file__).read().replace('\r\n', '\n'), __file__, 'exec'))" install --single-version-externally-managed --record /tmp/pip-b0GERp-record/install-record.txt --install-headers /home/chitra/purana/Documents/remo/remo/venv/include/site/python2.7 failed with error code 1 in /home/chitra/purana/Documents/remo/remo/venv/build/lxml
Storing complete log in /home/chitra/.pip/pip.log

What could be done to correct it?
Flags: needinfo?(dweeprk)
(Reporter)

Comment 6

4 years ago
In order to build python lxml package you have to install libxml2-dev in your system.
(Reporter)

Comment 7

4 years ago
Hi!

Any update with that issue?
Have you managed to setup your development environment?
Flags: needinfo?(dweeprk)
(Reporter)

Comment 8

4 years ago
Hi dweep, is there any progress with that bug? Another contributor has also expressed interest
to work on that. If you want to continue working, it's fine, else maybe we could reassign it.

Comment 9

4 years ago
Hi dweep,

You need to add the mysql username, password details in the remo/settings/local/py file before you could sync the DB i.e. ./manage.py syncdb && ./manage.py migrate.

Hi John,

I am able to setup the dev environment. Will keep you posted on this.

-- Prameet

Comment 10

4 years ago
Hi John,

I am done with the setup. Dev env is hot and up. I have looked into the bug and I think I ahave fixed it, but in order to verify it I would need to create a test remo profile, please guide me to do that. Please ping me when you are available.

Cheers,
Prameet
(Reporter)

Comment 11

4 years ago
Hi dweep,

Due to inactivity I am reassigning this bug to Prameet.
I am always happy to mentor a bug if you have the time. Feel free to ping me when you manage to setup your development environment and we will found you a new bug.

Thanks!
(Reporter)

Updated

4 years ago
Assignee: dweeprk → itsprameet
(Reporter)

Updated

4 years ago
Flags: needinfo?(dweeprk)
Status: NEW → ASSIGNED
(Reporter)

Comment 12

4 years ago
Hey Prameet!

Are you still working on that bug? Feel free to ping me for any help you want.
Flags: needinfo?(itsprameet)
(Reporter)

Comment 13

4 years ago
Due to inactivity I am marking this bug as NEW. Here [1] is the initial PR Prameet sent in case anyone wants to work on this.

Thanks!

[1] https://github.com/mozilla/remo/pull/661
Status: ASSIGNED → NEW
(Reporter)

Updated

4 years ago
Assignee: itsprameet → nobody
Mentor: jgiannelos@mozilla.com
Whiteboard: [kb=1263086] [good first bug][lang=python][mentor=jgiannelos@mozilla.com] → [kb=1263086] [good first bug][lang=python]
(Assignee)

Comment 14

3 years ago
I'm new to Mozilla. Can you assign this bug to me and I can get started?
(Reporter)

Comment 15

3 years ago
Hi! I am assigning this bug to you.
If you encounter any issues or have any questions, feel free to ping me in our IRC channel #remo-dev.
Here [1] you can find more info regarding the dev environment setup.

Thanks!

[1] http://remo.readthedocs.org/en/latest/
Assignee: nobody → xiaodi.yu
(Assignee)

Comment 16

3 years ago
Hi John,

Thanks you!

I am able to set up the environment on my local machine. I'm trying to get familiar with the project now.I have two questions for now.

1. After I set up the system, with 'git status', I got 
	modified:   vendor-local/src/django-database-email-backend (untracked content)
	modified:   vendor-local/src/happyforms (untracked content)
	modified:   vendor-local/src/jingo-offline-compressor (untracked content)
But I didn't change any of these files. Can you give me some ideas what they are and why they are there?

2. When I start editing, should I create a new branch? Is the 'master' branch where I should push back to? I'm still new to git and Github and this is the first project I fork on. Can you give me some help on the workflow?

Thanks,
Sean
(Reporter)

Comment 17

3 years ago
Hey Sean, I am answering inline,

> 1. After I set up the system, with 'git status', I got 
> 	modified:   vendor-local/src/django-database-email-backend (untracked
> content)
> 	modified:   vendor-local/src/happyforms (untracked content)
> 	modified:   vendor-local/src/jingo-offline-compressor (untracked content)
> But I didn't change any of these files. Can you give me some ideas what they
> are and why they are there?
Have you used the ``--recursive`` option? You need to fetch some submodules as well. Other than that you can check with git status to see what's changed. Its probably a .pyc file.

> 2. When I start editing, should I create a new branch? Is the 'master'
> branch where I should push back to? I'm still new to git and Github and this
> is the first project I fork on. Can you give me some help on the workflow?

Our git workflow is the following:
* For each new bug or feature we create a new branch from master (usually with the bug number as a name).
* We use the prefix [fix bug <bug number>] in our commit messages in order the bugzilla bot to automatically close resolved bugs.
* We send pull requests from the new branch in our fork to mozilla master remo branch.
(Assignee)

Comment 18

3 years ago
Thanks, John.

I did user the "--recursive" option. I looked into these directories and found that the changes are .pyc files. However, they should be ignored according to .gitignore. I don't know why this happens.

I have made a pull request on github about this bug. Please take a look whenever you have time.


(In reply to John Giannelos [:nemo] from comment #17)
> Hey Sean, I am answering inline,
> 
> > 1. After I set up the system, with 'git status', I got 
> > 	modified:   vendor-local/src/django-database-email-backend (untracked
> > content)
> > 	modified:   vendor-local/src/happyforms (untracked content)
> > 	modified:   vendor-local/src/jingo-offline-compressor (untracked content)
> > But I didn't change any of these files. Can you give me some ideas what they
> > are and why they are there?
> Have you used the ``--recursive`` option? You need to fetch some submodules
> as well. Other than that you can check with git status to see what's
> changed. Its probably a .pyc file.
> 
> > 2. When I start editing, should I create a new branch? Is the 'master'
> > branch where I should push back to? I'm still new to git and Github and this
> > is the first project I fork on. Can you give me some help on the workflow?
> 
> Our git workflow is the following:
> * For each new bug or feature we create a new branch from master (usually
> with the bug number as a name).
> * We use the prefix [fix bug <bug number>] in our commit messages in order
> the bugzilla bot to automatically close resolved bugs.
> * We send pull requests from the new branch in our fork to mozilla master
> remo branch.

Comment 19

3 years ago
Just tapping on the glass here - Nemo, has this been resolved over at Github?
Flags: needinfo?(jgiannelos)
(Reporter)

Comment 20

3 years ago
I added a comment to this [1] PR and when that change is ready we can merge.

[1] https://github.com/mozilla/remo/pull/789
Flags: needinfo?(jgiannelos)

Comment 21

3 years ago
Commits pushed to master at https://github.com/mozilla/remo

https://github.com/mozilla/remo/commit/5bbf5d29969a80f62fe22cfbb6619f3609ae4f2e
[Fix bug 968094] Fix plural 'activity' strings in reps dashboard.

https://github.com/mozilla/remo/commit/03d48e1f0bf3f9bf494667c25b4e6de183fd7fec
Merge pull request #808 from johngian/pr-789

[Fix bug 968094] Fix plural 'activity' strings in reps dashboard.

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED

Updated

3 years ago
Version: unspecified → next
(Reporter)

Updated

3 years ago
Whiteboard: [kb=1263086] [good first bug][lang=python] → [good first bug][lang=python]
(Reporter)

Updated

3 years ago
Whiteboard: [good first bug][lang=python] → [kb=1493338] [good first bug][lang=python]
(Reporter)

Comment 22

3 years ago
Verified on stage:

* Now plural strings are correct
** 0 activities
** 1 activity
** (>1) activities
Status: RESOLVED → VERIFIED
(Reporter)

Updated

3 years ago
Version: next → 439
(Reporter)

Updated

3 years ago
Flags: needinfo?(itsprameet)
You need to log in before you can comment on or make changes to this bug.