Taping the cancel button in rocketbar always get you to the homescreen

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: etienne, Assigned: kgrandon)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
If you open the rocketbar from an app, then tap cancel to go out, you should get back to your app, not the homescreen.

Since I open it by accident a lot, it makes it even worse :/
(Assignee)

Comment 1

5 years ago
I suppose you can tap on the card to open it :)

We need some UX decisions here I think. What if you close the current card or navigate to another card? 

Francis - any opinion on what to do here? I tried searching the spec but couldn't find these cases covered. Can we update the spec with something here?
Flags: needinfo?(fdjabri)

Updated

5 years ago
Blocks: 946452
Summary: Taping the cancel button in rocketbar alwas get you to the homescreen → Taping the cancel button in rocketbar always get you to the homescreen
(Assignee)

Comment 2

5 years ago
I checked with Francis and Eric and we decided that cancel should open the currently active card if there is one.
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Flags: needinfo?(fdjabri)
(Assignee)

Comment 3

5 years ago
Created attachment 8371335 [details] [review]
Github pull request

Aus - would you have time for a quick review?
Attachment #8371335 - Flags: review?(aus)

Comment 4

5 years ago
Comment on attachment 8371335 [details] [review]
Github pull request

Looks good Kevin!
Attachment #8371335 - Flags: review?(aus) → review+
(Assignee)

Comment 5

5 years ago
Landed: https://github.com/mozilla-b2g/gaia/commit/8e036cd7fb9902ec60349540bb766cf38ac75093
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.