Closed
Bug 968110
Opened 11 years ago
Closed 11 years ago
[costcontrol] Javascript error when open a notification when the application is closed
Categories
(Firefox OS Graveyard :: Gaia::Cost Control, defect)
Tracking
(blocking-b2g:1.3T+, b2g-v1.3T fixed, b2g-v1.4 fixed)
RESOLVED
FIXED
blocking-b2g | 1.3T+ |
People
(Reporter: mai, Assigned: mai)
References
Details
Attachments
(1 file)
Preconditions: Costcontrol application must be closed and it's necessary receive a costcontrol notification.
STR:
1. After receiving a notification.
2. slide down the utility tray
3. Tap on the notification message.
4. look at logcat
## Expected :
1. no error messages
## Actual :
E/GeckoConsole( 5913): [JavaScript Error: "TypeError: window.parent.CostControlApp is undefined" {file: "app://costcontrol.gaiamobile.org/js/message_handler.js" line: 293}]
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → mri
Assignee | ||
Comment 1•11 years ago
|
||
Please, could your review the code?
Attachment #8370675 -
Flags: review?(salva)
Comment 2•11 years ago
|
||
Comment on attachment 8370675 [details] [review]
patch v1.0
Working perfectly. Thank you!
Attachment #8370675 -
Flags: review?(salva) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Master: f8e91dda659a531e7bed27070ccb02987dd0cf23
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 4•11 years ago
|
||
nominating to v1.3T since it blocks a blocker (Bug 858017). Thanks!
blocking-b2g: --- → 1.3T?
status-b2g-v1.3T:
--- → affected
Comment 5•11 years ago
|
||
Hi James, Ying, please take it for v1.3T. Thanks!
blocking-b2g: 1.3T? → 1.3+
Flags: needinfo?(ying.xu)
Flags: needinfo?(james.zhang)
Comment 6•11 years ago
|
||
Flags: needinfo?(james.zhang)
Comment 7•11 years ago
|
||
So, do we need this commit on 1.3 or only 1.3t? Steve, why did you switch from 1.3T? to 1.3+ in comment 5?
Flags: needinfo?(styang)
Comment 8•11 years ago
|
||
wrong setting. Should be 1.3T.
blocking-b2g: 1.3+ → 1.3T+
Flags: needinfo?(styang)
Updated•11 years ago
|
status-b2g-v1.4:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•