Closed Bug 968110 Opened 11 years ago Closed 11 years ago

[costcontrol] Javascript error when open a notification when the application is closed

Categories

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

(blocking-b2g:1.3T+, b2g-v1.3T fixed, b2g-v1.4 fixed)

RESOLVED FIXED
blocking-b2g 1.3T+
Tracking Status
b2g-v1.3T --- fixed
b2g-v1.4 --- fixed

People

(Reporter: mai, Assigned: mai)

References

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
salva
: review+
Details | Review
Preconditions: Costcontrol application must be closed and it's necessary receive a costcontrol notification. STR: 1. After receiving a notification. 2. slide down the utility tray 3. Tap on the notification message. 4. look at logcat ## Expected : 1. no error messages ## Actual : E/GeckoConsole( 5913): [JavaScript Error: "TypeError: window.parent.CostControlApp is undefined" {file: "app://costcontrol.gaiamobile.org/js/message_handler.js" line: 293}]
Assignee: nobody → mri
Attached file patch v1.0
Please, could your review the code?
Attachment #8370675 - Flags: review?(salva)
Comment on attachment 8370675 [details] [review] patch v1.0 Working perfectly. Thank you!
Attachment #8370675 - Flags: review?(salva) → review+
Master: f8e91dda659a531e7bed27070ccb02987dd0cf23
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Blocks: 858017
nominating to v1.3T since it blocks a blocker (Bug 858017). Thanks!
blocking-b2g: --- → 1.3T?
Hi James, Ying, please take it for v1.3T. Thanks!
blocking-b2g: 1.3T? → 1.3+
Flags: needinfo?(ying.xu)
Flags: needinfo?(james.zhang)
Flags: needinfo?(ying.xu)
So, do we need this commit on 1.3 or only 1.3t? Steve, why did you switch from 1.3T? to 1.3+ in comment 5?
Flags: needinfo?(styang)
wrong setting. Should be 1.3T.
blocking-b2g: 1.3+ → 1.3T+
Flags: needinfo?(styang)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: