968111 - Fix various XUL files' accessibility markup throughout Toolkit

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Marco Zehe (:MarcoZ)]

Attachment: ImproveXulMarkup.diff

These fix errors that crept in overtime, mainly:

1. Replace "for" with "control" in XUL label usage. In XUL, as opposed to HTML, the attribute name to associate alabel with a control is "control", not "for".
2. Add explicit dialog descriptions so screen readers won't have to crawl through the static text elements and maybe pick up extraneous stuff. Improves the initial reading experience when these windows/dialogs open.
3. Add missing associations of labels and controls in some places.

Comment 1

[Dão Gottwald [:dao]]

Comment on attachment 8370641 [details] [diff] [review]
ImproveXulMarkup.diff

>--- a/toolkit/components/viewconfig/content/config.xul
>+++ b/toolkit/components/viewconfig/content/config.xul

> <window id="config"
>         xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" 
>         title="&window.title;"
>         windowtype="Preferences:ConfigManager"
>         role="application"
>+        aria-describedby="warningTitle warningText"
>         width="750"
>         height="500"
>         disablefastfind="true"
>         onunload="onConfigUnload();"
>         onload="onConfigLoad();">

about:config allows the user to disable the warning such that it won't show again when opening about:config. How will aria-describedby="warningTitle warningText" be handled in that case?

>--- a/toolkit/mozapps/handling/content/dialog.xul
>+++ b/toolkit/mozapps/handling/content/dialog.xul

>-  <checkbox id="remember" oncommand="dialog.onCheck();"/>
>+  <checkbox id="remember" aria-labelledby="remember-text" oncommand="dialog.onCheck();"/>
>   <description id="remember-text"/>

toolkit/mozapps/handling/content/dialog.js sets a label attribute on the checkbox. How will this be handled when there's also the aria-labelledby attribute?

Comment 2

[Marco Zehe (:MarcoZ)]

(In reply to Dão Gottwald [:dao] from comment #1)
> about:config allows the user to disable the warning such that it won't show
> again when opening about:config. How will aria-describedby="warningTitle
> warningText" be handled in that case?

It'll just produce an empty string. And this would then be expected. So it won't crash or anything.

> toolkit/mozapps/handling/content/dialog.js sets a label attribute on the
> checkbox. How will this be handled when there's also the aria-labelledby
> attribute?

ARIA usually wins over native markup when present, especially in the label case. Would aria-describedby, e. g. turning this into an optional description and leaving the label alone, be appropriate? That way, the text in the description element will be spoken if no label is there, and it will be spoken in addition to the label set by JS.

Comment 3

[Dão Gottwald [:dao]]

> > toolkit/mozapps/handling/content/dialog.js sets a label attribute on the
> > checkbox. How will this be handled when there's also the aria-labelledby
> > attribute?
> 
> ARIA usually wins over native markup when present, especially in the label
> case. Would aria-describedby, e. g. turning this into an optional
> description and leaving the label alone, be appropriate? That way, the text
> in the description element will be spoken if no label is there, and it will
> be spoken in addition to the label set by JS.

That sounds better.

Comment 4

[Marco Zehe (:MarcoZ)]

(In reply to Dão Gottwald [:dao] from comment #3)
> That sounds better.

Fixed locally.

Comment 5

[Marco Zehe (:MarcoZ)]

Attachment: ImproveXulMarkup.diff

Addressed comment.

Comment 6

[Marco Zehe (:MarcoZ)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/074f7372e03b

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/074f7372e03b