968150 - Investigate intermittent "test_sms_to_dialer" fail

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[[:AndreiH]]

I could reproduce this locally, when running the test locally the Messages app sometimes does not launch.

Traceback (most recent call last):
File "/var/jenkins/workspace/b2g.hamachi.mozilla-central.ui.2/.env/local/lib/python2.7/site-packages/marionette_client-0.7.3-py2.7.egg/marionette/marionette_test.py", line 143, in run
testMethod()
File "/var/jenkins/workspace/b2g.hamachi.mozilla-central.ui.2/tests/python/gaia-ui-tests/gaiatest/tests/functional/messages/test_sms_to_dialer.py", line 24, in test_dialer_from_message
self.messages.launch()
File "/var/jenkins/workspace/b2g.hamachi.mozilla-central.ui.2/tests/python/gaia-ui-tests/gaiatest/apps/messages/app.py", line 18, in launch
Base.launch(self)
File "/var/jenkins/workspace/b2g.hamachi.mozilla-central.ui.2/tests/python/gaia-ui-tests/gaiatest/apps/base.py", line 27, in launch
self.app = self.apps.launch(self.name, launch_timeout=launch_timeout)
File "/var/jenkins/workspace/b2g.hamachi.mozilla-central.ui.2/tests/python/gaia-ui-tests/gaiatest/gaia_test.py", line 91, in launch
self.switch_to_frame(app.frame_id, url)
File "/var/jenkins/workspace/b2g.hamachi.mozilla-central.ui.2/tests/python/gaia-ui-tests/gaiatest/gaia_test.py", line 157, in switch_to_frame
self.marionette.switch_to_frame(app_frame)
File "/var/jenkins/workspace/b2g.hamachi.mozilla-central.ui.2/.env/local/lib/python2.7/site-packages/marionette_client-0.7.3-py2.7.egg/marionette/marionette.py", line 882, in switch_to_frame
response = self._send_message('switchToFrame', 'ok', element=frame.id, focus=focus)
File "/var/jenkins/workspace/b2g.hamachi.mozilla-central.ui.2/.env/local/lib/python2.7/site-packages/marionette_client-0.7.3-py2.7.egg/marionette/marionette.py", line 595, in _send_message
raise TimeoutException(message='socket.timeout', status=ErrorCodes.TIMEOUT, stacktrace=None)
TimeoutException: TimeoutException: socket.timeout

Comment 1

[[:AndreiH]]

This seems kinda strange. The Messages app sometimes is successfully launched and sometimes it's not.
I think  the test is moving fast, if I put a sleep here [1], the test always passes

[1] https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/messages/test_sms_to_dialer.py#L16

Comment 2

[[:AndreiH]]

I think " GaiaDataLayer.sendSMS(%s, %s) " is executed to fast, before the phone could properly startup

Comment 3

[Zac C (:zac)]

When an SMS is received, if the Messages app is not open it is opened by the System.

It's possibly a race between the two.

If you shuffle the order between sending the SMS and opening the Message app it might stabilise.

Comment 4

[Zac C (:zac)]

(In reply to [:AndreiH] from comment #2)
> I think " GaiaDataLayer.sendSMS(%s, %s) " is executed to fast, before the
> phone could properly startup

When you saw it locally was the SMS received?

Comment 5

[[:AndreiH]]

The notification of receiving a message is not displayed only after I open the Message app. Even tried with several sms and only after I Messages app is opened all the notifications are displayed

Comment 6

[Zac C (:zac)]

All I mean is that if GaiaDataLayer.sendSMS still worked and sent the SMS then it did not execute too fast.

Comment 7

[Zac C (:zac)]

I debugged this a bit more and I think that Marionette is tapping on the element before it has its click handler added:
https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/contacts/js/contacts.js#L630

If you view the logcat when it fails you see in the logs that Marionette taps on the button but on the device you see nothing happens.

However I'm not sure what to wait for just yet.

Comment 8

[Zac C (:zac)]

Attachment: github pr

Comment 9

[Florin Strugariu [:Bebe]]

Comment on attachment 8377089 [details] [review]
github pr

R- because of the missing import

Comment 10

[Zac C (:zac)]

Comment on attachment 8377089 [details] [review]
github pr

r? again :)

Comment 11

[Florin Strugariu [:Bebe]]

merged in:
https://github.com/mozilla-b2g/gaia/commit/5db034fc7aefd7b592ce1546c4da9ac2fc517e74