Closed Bug 968221 Opened 6 years ago Closed 6 years ago

Stop setting a text-shadow for Aero Glass on the tabs toolbar only to remove it from individual tabs later on

Categories

(Firefox :: Theme, defect)

All
Windows 7
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 30

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
We set a white text-shadow on the tabs toolbar for toolbar items that display text, and we removed that text-shadow from tabs since they used to have their own opaque background even on Aero Glass. The latter doesn't make sense anymore, since background tabs don't have that opaque background anymore. On the other hand, the blue fog behind the tabs toolbar made the text-shadow unnecessary.
Attachment #8370768 - Flags: review?(MattN+bmo)
Comment on attachment 8370768 [details] [diff] [review]
patch

Sorry for the delay. I didn't see any fallout on Windows 7 Aero.
Attachment #8370768 - Flags: review?(MattN+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/3565df262e98
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
Keywords: verifyme
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0

Verified as fixed on Firefox 30 beta 3, build ID: 20140508121358.
Status: RESOLVED → VERIFIED
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.