Closed Bug 968294 Opened 10 years ago Closed 10 years ago

Refresh authentication UI

Categories

(Firefox OS Graveyard :: FxA, defect)

Product:
Firefox OS Graveyard
Component:
FxA
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: ferjm, Assigned: ferjm)

References

Details

Attachments

(1 file, 3 obsolete files)

Github PR
46 bytes, text/x-github-pull-request
alive
: review+
Details | Review
Component: Identity → FxA
Product: Core → Firefox OS
Assignee: nobody → ferjmoreno
Hey Fernando --

Thanks for jumping on this. I want to make sure you coordinate with Jared. I will send you a link to more recent screens.
Flags: needinfo?(6a68)
ferjm, [1] is the dropbox with the latest screens. jgruen may have newer stuff coming, but I bet it won't vary too much from what's already there. let me know if I can help with anything else

[1] https://www.dropbox.com/sh/8o3t73g2lb07514/TMsyjv8Rlc
Flags: needinfo?(6a68)
Attached file Gaia branch WIP (obsolete) — 
Thanks Jared!

I'll be working on this branch
I still need to work on the unit tests, but I can use some feedback in the meantime :).
Attachment #8371673 - Attachment is obsolete: true
Attachment #8373465 - Flags: feedback?(borja.bugzilla)
Attached patch Diff (obsolete) — — Splinter Review 

    
    

    
  
Comment on attachment 8373465 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16139/files

I've added some comments and found an issue:
https://github.com/mozilla-b2g/gaia/pull/16139#issuecomment-34859330

Could you take a look? Ask me to feedback/review again when ready!

        Attachment #8373465 -
        Flags: feedback?(borja.bugzilla)

    
    

    
  

      
      
      
      

        Attached file
          
        Github PR
        — 
      

    


  
Now with unit tests and feedback addressed.

        Attachment #8373465 -
        Attachment is obsolete: true

        Attachment #8373469 -
        Attachment is obsolete: true

        Attachment #8377185 -
        Flags: review?(borja.bugzilla)

        Attachment #8377185 -
        Flags: review?(alive)

    
  

        Attachment #8377185 -
        Attachment description: Githib PR → Github PR

    
  

        Attachment #8377185 -
        Flags: review?(borja.bugzilla) → feedback?(borja.bugzilla)

    
    

    
  
Comment on attachment 8377185 [details] [review]
Github PR

nits

        Attachment #8377185 -
        Flags: review?(alive) → review+

    
  

        Attachment #8377185 -
        Flags: feedback?(borja.bugzilla)

    
  
Blocks: 955952

    
    

    
  
https://github.com/mozilla-b2g/gaia/commit/54cfb7207cf5b5ca12006f0fedb57b36f861cf55
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: in-moztrap+
Resolution: --- → FIXED
Whiteboard: [in-carajillo]
Depends on: 979990

    
    

    
  
Fernando: Alive: It's usually not a good thing to add files to xfail.list. We're trying to get this file to 0 lines. (I know, it's at 1207 lines currently so long road)

    
    

    
  
Yes, sorry about missing that part. I will pay attention to this. Thanks for reminding!

    
    

    
  
You are right, we've been lazy in fxa about that. Fixing it on bug 980184

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: