96839 - Creating a table from selection and choosing to not delete character separator does not work properly

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect)

Description

[TucsonTester2]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9.3+) Gecko/20010821
Netscape6/6.1b1
BuildID:    20010821

While creating a table from a selection I choose the comma option and then
unchecked "Delete separator character".  Then I clicked ok and it created a
table that only had a long row with all of my information still in text form
with it's commas.

When I put the check back in the option to "Delete separator character", I was
able to have my table created with each word placed in separate cells.

Reproducible: Always
Steps to Reproduce:
1.Open composer
2.Type in the following text; cell1,cell2,cell3,cell4,cell5,cell6
3.Click on the edit menu and choose select all
4.Click the table button in the toolbar
5.Choose the Comma option
6.Take the check out of the "Delete separator character" and click ok


Actual Results:  The table is not made properly.  Instead of giving me a
seperate cell for each cell"#" You only get one row with one column.

Expected Results:  There should be a seperate cell for each cell"#". The table
is made properly if you put the check back into the "Delete separator character"
or if you add a space after each comma.

Comment 1

[Kathleen :Brade]

-->cmanske
is this a duplicate?

Comment 2

[Charles Manske]

Not a dup.
Ok, so I'm fixing the multiple "Convert to table bugs" together. I'll put the
relevant parts of the total patch in each bug.
For this bug, the problem is in EdConvertToTable.xul:
-  <checkbox id="DeleteSepCharacter" label="&deleteCharCheck.label;"
oncommand="SelectCharacter('1');"/>
+  <checkbox id="DeleteSepCharacter" label="&deleteCharCheck.label;"
persist="checked"/>

we shouldn't be calling the oncommand handler SelectCharacter('1'), which is
only for "space" separator.

Comment 3

[Charles Manske]

The patch attached to bug 82409 has fix described above.

Comment 4

[TucsonTester2]

Attachment: Table Example

Comment 5

[TucsonTester2]

Just a quick note, if you enter in a space before and after the comma in the
sentence then there will be a seperate cell for the comma and the cell content
after it.  So let's say that in step 2 you put a space before and after every
comma.  When you create a new table from the selection and choose to not delete
the separator character you will recieve a table having cells with cell# and
commas in seperate cells.  This is still with the option of choosing commas as
the seperator.

Above is an attachment showing the table created from the above steps.

Comment 6

[Charles Manske]

What you describe is fixed by the patch on bug 82409.
Did someone remove the "depends" link to that?

Comment 7

[Charles Manske]

r=brade, sr=kin (done in bug 82409 for the patch that fixes all tableize bugs)

Comment 8

[Charles Manske]

checked in.

Comment 9

[sujay]

verified in 9/4 build.