968403 - Figure out what to do with preprocessed mochitests

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(not currently active) Ted Mielczarek]

We've got some mochitests that get preprocessed, for example:
http://mxr.mozilla.org/mozilla-central/source/browser/components/preferences/tests/Makefile.in#10

We either need to support preprocessing mochitests in manifest files, or we need to fix all the tests that rely on this. The former seems simpler, but if it's just a handful of tests perhaps we can get it done easily.

Comment 1

[(not currently active) Ted Mielczarek]

More:
http://mxr.mozilla.org/mozilla-central/source/browser/components/preferences/in-content/tests/Makefile.in#10
http://mxr.mozilla.org/mozilla-central/source/browser/components/search/test/Makefile.in#13
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/ctypes/tests/Makefile.in#28

Not sure if this is exhaustive.

Comment 2

[(not currently active) Ted Mielczarek]

Attachment: Switch some tests to not use preprocessing

This is not comprehensive, I just wanted to get a checkpoint up here. I'm going to just fix things to not use preprocessing.

Comment 3

[(not currently active) Ted Mielczarek]

Attachment: Switch some tests to not use preprocessing

I think this covers most of the tests that were preprocessed. There are still a few left, but we'll get them cleaned up eventually.

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 8379816 [details] [diff] [review]
Switch some tests to not use preprocessing

Review of attachment 8379816 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/preferences/tests/browser.ini
@@ +10,5 @@
>  [browser_healthreport.js]
>  skip-if = (!healthreport) || (os == 'linux' && debug)
>  [browser_permissions.js]
>  [browser_privacypane_1.js]
> +[browser_privacypane_4.js]

1-4-3-5?

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8379816 [details] [diff] [review]
Switch some tests to not use preprocessing

Review of attachment 8379816 [details] [diff] [review]:
-----------------------------------------------------------------

thanks, this is really nice to see the cleanup here.

Comment 6

[(not currently active) Ted Mielczarek]

Had to fiddle a few things because this patch was sort of busted as written (you can't + Arrays in JS, oops). The resulting try run looks a lot better:
https://tbpl.mozilla.org/?tree=Try&rev=95633282cbba

Comment 7

[(not currently active) Ted Mielczarek]

https://hg.mozilla.org/integration/mozilla-inbound/rev/28b40ecf6345

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/28b40ecf6345