968454 - [Settings] Developer settings menu item needs an icon

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Eitan Isaacson [:eeejay]]

Currently it is using the accessibility icon, which will look strange once bug #952312 lands.

Comment 1

[Jan Keromnes [:janx]]

Attachment: gaia pull request

Moved over from bug #963039.

Comment 2

[Anthony Ricaud (:rik)]

Comment on attachment 8379092 [details] [review]
gaia pull request

I'm not a settings peer so forwarding this.

A few notes:
- have you ran tools/png_recompress.sh on this image?
- We should update the @2x version also.

Comment 3

[Jan Keromnes [:janx]]

(In reply to Anthony Ricaud (:rik) from comment #2)
> - have you ran tools/png_recompress.sh on this image?

I'm not sure this works on Gif images. My pull request doesn't change current sizes, and Gimp is not able to compress better:

12K     icons_sprite.gif
12K     icons_sprite_active.gif
16K     [e-mail]
16K     [e-mail]

> - We should update the @2x version also.

The 2x versions don't seem to be in sync with the 1x and 1.5x versions. Carol didn't send me an updated 2x version, so I suppose it was not necessary?

Comment 4

[Carol Huang [:Carol]]

Attachment: [e-mail]

Hello Jan,
I added the 2x version to the attachment.
thanks :)

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8379092 [details] [review]
gaia pull request

r=me with the 2x icons added. Thanks for the patch!

Comment 6

[Jan Keromnes [:janx]]

Thanks all! I'm not sure the @2x icon is actually used anywhere, because it wasn't updated for a while.

Comment 7

[Gabriele Svelto [:gsvelto] (PTO)]

Quick question here, the new files are in GIF format but pretty much all of our Gaia assets are in PNG format. Converting the images to PNG and then compressing them as Anthony has suggested in comment 2 provides a nice reduction in size (the images get roughly 1/3 smaller), could we do that?

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

The sprites were changed to GIF format for speedup the startup performance (versus PNG format with alpha channel). Please refer to https://bugzilla.mozilla.org/show_bug.cgi?id=840627 for details.