Closed Bug 968456 Opened 10 years ago Closed 10 years ago

Put a Scrollable Opaque Background Behind the Music App

Categories

(Firefox OS Graveyard :: Gaia::Music, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::Music
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
1.4 S1 (14feb)

People

(Reporter: mchang, Assigned: mchang)

References

Details

(Keywords: perf, Whiteboard: [c=handeye p=1 s= u=])

Attachments

(1 file, 2 obsolete files)

https://github.com/mozilla-b2g/gaia/pull/16157
46 bytes, text/x-github-pull-request
dkuo
: review+
Details | Review 
      No description provided.
Attachment #8371083 - Flags: review?(dkuo)
Comment on attachment 8371083 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/16005

Mason, since this patch is about the performance and just modify the css, the code looks good to me, however, it changes the style of the list item(see github comment for detail), so please address the issue before you land it, thanks.
Attachment #8371083 - Flags: review?(dkuo) → review+
Comment on attachment 8371083 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/16005

Hi Dominic, thanks for catching that visual different. I fixed it up, but had to change some of the HTML for the subview. Can you take one more look at it please?

Thanks!
Flags: needinfo?(dkuo)
Hopefully last try.
Attachment #8371083 - Attachment is obsolete: true
Attachment #8373876 - Flags: review?(dkuo)
Flags: needinfo?(dkuo)

        Attachment #8373876 -
        Attachment is obsolete: true

        Attachment #8373876 -
        Flags: review?(dkuo)

        Attachment #8373889 -
        Flags: review?(dkuo)

    
    

    
  
Comment on attachment 8373889 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/16157

Thanks Mason, the patch looks good to me! and travis is green now I am going to land it for you.

        Attachment #8373889 -
        Flags: review?(dkuo) → review+

    
    

    
  
Mason, because of the commit message of your patch did not follow the format in gaia, so I cherry-picked you commit and landed it in another PR, thanks for working on this!

Landed on master: 3fe0b967077c676a861f4612eedf14af2908ab74
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: