Closed
Bug 968465
Opened 11 years ago
Closed 11 years ago
[Settings] Auto show/hide developer menu with new magic attribute
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: eeejay, Assigned: eeejay)
References
Details
Attachments
(1 file)
An attribute was introduced in bug #952312 that allows panels to be shown or hidden depending on settings.
|
Assignee | |
Updated•11 years ago
|
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → eitan
Component: Gaia → Gaia::Settings
Summary: Auto show/hide developer menu with new magic attribute → [Settings] Auto show/hide developer menu with new magic attribute
|
|
Assignee | |
Comment 1•11 years ago
|
||
This is based off of the yet-to-be-merged branch in bug #952312.
Attachment #8371061 -
Flags: review?(kaze)
|
||
Comment 2•11 years ago
|
||
Please squash and rebase your pull request. At the moment it’s hard to tell the difference from yesterday’s commit: https://github.com/mozilla-b2g/gaia/commit/334bfb1bebb1f1e3083cfbc3fdbe1c03dfc64f7d
|
|
Assignee | |
Comment 3•11 years ago
|
||
Rebased.
|
|
||
Comment 4•11 years ago
|
||
Comment on attachment 8371061 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16006
I love this `data-show-name` attribute already. :-)
Attachment #8371061 -
Flags: review?(kaze) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•