Closed Bug 968465 Opened 9 years ago Closed 9 years ago

[Settings] Auto show/hide developer menu with new magic attribute

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Settings
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: eeejay, Assigned: eeejay)

References

Details

Attachments

(1 file)

Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16006
46 bytes, text/x-github-pull-request
kaze
: review+
Details | Review 
An attribute was introduced in bug #952312 that allows panels to be shown or hidden depending on settings.
No longer blocks: gaiaa11y
Keywords: access
Assignee: nobody → eitan
Component: Gaia → Gaia::Settings
Summary: Auto show/hide developer menu with new magic attribute → [Settings] Auto show/hide developer menu with new magic attribute
This is based off of the yet-to-be-merged branch in bug #952312.
Attachment #8371061 - Flags: review?(kaze)
Please squash and rebase your pull request. At the moment it’s hard to tell the difference from yesterday’s commit: https://github.com/mozilla-b2g/gaia/commit/334bfb1bebb1f1e3083cfbc3fdbe1c03dfc64f7d
Rebased.
Comment on attachment 8371061 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16006

I love this `data-show-name` attribute already. :-)
Attachment #8371061 - Flags: review?(kaze) → review+
https://github.com/mozilla-b2g/gaia/commit/c273bd6525f7f295539592ce74d5e6b225d53be1
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.