968542 - IPC blobs can entrain a ContentParent

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patc

Something I've noticed while debugging Bug 963290 is that IPC Blobs can entrain the ContentParent.  I don't think we can rely on the page allowing the blob to be GCd, but I'm not 100% convinced that this is the right fix.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 8371130 [details] [diff] [review]
Patc

Review of attachment 8371130 [details] [diff] [review]:
-----------------------------------------------------------------

I think this looks fine! Except:

::: dom/ipc/Blob.cpp
@@ +954,5 @@
>        MOZ_ASSERT(mActor);
>        MOZ_ASSERT(!mSlice);
>        MOZ_ASSERT(!mDone);
>  
> +      NS_ENSURE_TRUE(mActor->Manager(), NS_ERROR_UNEXPECTED);

This is a void function

Comment 2

[Johnny Stenback (:jst)]

Attachment: Patch, fixed per review comment.

Fixed up, ready to land. Carrying over bent's r+. (and I would've landed this had the tree been open)

Comment 3

[Johnny Stenback (:jst)]

Attachment: Patch, fixed per review comment.

Now with checkin comment etc.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/930f356f1a36

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8372668 [details] [diff] [review]
Patch, fixed per review comment.

Please just use checkin-needed ;)

Comment 6

[Johnny Stenback (:jst)]

Will do! (too many flags to keep track of) Thanks for landing this!

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/930f356f1a36

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/ee9ac69ab935