Closed Bug 968569 Opened 9 years ago Closed 9 years ago

[LockScreen] Set LockScreen's background as an individual element to boost performance

Categories

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gweng, Assigned: gweng)

References

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
timdream
: review+
Details | Review
In the progress of solving Bug 945082, Jerry has told me that if we can stop overlay children inside a container while the animation is performing, we would have a way to boost the performance. To achieve this, we need a individual background element instead of using the container's background. So I opened this bug.

The other reason to fire this bug is it seems that the Bug 945082 would have lots of solutions, and this can be landed individually.
And I previously duplicated the Bug 956621 because I though that is one possible solution of the Bug 945082, but I found that it may be not proper to fire so many patches include Gecko and Gaia patches in the same bug, so now I want to solve this similar issue but with different reason.
Assignee: nobody → gweng
Attached file Patch
The patch passed all tests:

https://travis-ci.org/mozilla-b2g/gaia/builds/18316800

But I now found it has some problem while playing music, so I would keep to fix it.
Comment on attachment 8371202 [details] [review]
Patch

The media widget problem had been solved, and the test is re-running. So I now set the reviewer.
Attachment #8371202 - Flags: review?(timdream)
Comment on attachment 8371202 [details] [review]
Patch

Please add comments in CSS or HTML, since the fix seems counter-intuitive.
Attachment #8371202 - Flags: review?(timdream) → review+
master: https://github.com/mozilla-b2g/gaia/commit/0125235f3a11bc425d658b4c192472ba312af784
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Depends on: 971392
Depends on: 971423
You need to log in before you can comment on or make changes to this bug.