968569 - [LockScreen] Set LockScreen's background as an individual element to boost performance

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Greg Weng [:snowmantw][:gweng][:λ]]

In the progress of solving Bug 945082, Jerry has told me that if we can stop overlay children inside a container while the animation is performing, we would have a way to boost the performance. To achieve this, we need a individual background element instead of using the container's background. So I opened this bug.

The other reason to fire this bug is it seems that the Bug 945082 would have lots of solutions, and this can be landed individually.

Comment 1

[Greg Weng [:snowmantw][:gweng][:λ]]

And I previously duplicated the Bug 956621 because I though that is one possible solution of the Bug 945082, but I found that it may be not proper to fire so many patches include Gecko and Gaia patches in the same bug, so now I want to solve this similar issue but with different reason.

Comment 2

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch

The patch passed all tests:

https://travis-ci.org/mozilla-b2g/gaia/builds/18316800

But I now found it has some problem while playing music, so I would keep to fix it.

Comment 3

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8371202 [details] [review]
Patch

The media widget problem had been solved, and the test is re-running. So I now set the reviewer.

Comment 4

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8371202 [details] [review]
Patch

>https://github.com/mozilla-b2g/gaia/pull/16013

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8371202 [details] [review]
Patch

Please add comments in CSS or HTML, since the fix seems counter-intuitive.

Comment 6

[Greg Weng [:snowmantw][:gweng][:λ]]

master: https://github.com/mozilla-b2g/gaia/commit/0125235f3a11bc425d658b4c192472ba312af784