968606 - HTTP cache v2: audit old cache usage

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect)

Description

[Honza Bambas (:mayhemer)]

No new found, but one forgotten:

http://mxr.mozilla.org/mozilla-central/source/browser/components/preferences/in-content/advanced.js#404

Comment 1

[Honza Bambas (:mayhemer)]

Attachment: v1

One place I found where the new HTTP cache API is not used yet.

Comment 2

[Brian R. Bondy [:bbondy]]

Comment on attachment 8373541 [details] [diff] [review]
v1

Review of attachment 8373541 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/preferences/in-content/advanced.js
@@ +400,5 @@
>     * Clears the cache.
>     */
>    clearCache: function ()
>    {
> +    Services.cache2.clear();

This file should stay in sync with advanced.js.
Did something change in advanced.js recentlyt hat's not reflected in dxr?
http://dxr.mozilla.org/mozilla-central/source/browser/components/preferences/advanced.js#414

Comment 3

[Honza Bambas (:mayhemer)]

I'm not sure I follow - you want the code be same?  Like: don't use Services and leave the {try catch}?

Comment 4

[Brian R. Bondy [:bbondy]]

The code in in content preferences should match the code in normal preferences. If you want to make this change, then it should be done in both places and not only one place.

Comment 5

[Honza Bambas (:mayhemer)]

Got it.  New patch will come.  Thanks.

Comment 6

[Honza Bambas (:mayhemer)]

Attachment: v2

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/7ec73b94e194