HTTP cache v2: audit old cache usage

RESOLVED FIXED in mozilla30

Status

()

Core
Networking: Cache
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mayhemer, Assigned: mayhemer)

Tracking

Trunk
mozilla30
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
No new found, but one forgotten:

http://mxr.mozilla.org/mozilla-central/source/browser/components/preferences/in-content/advanced.js#404
(Assignee)

Comment 1

4 years ago
Created attachment 8373541 [details] [diff] [review]
v1

One place I found where the new HTTP cache API is not used yet.
Assignee: nobody → honzab.moz
Status: NEW → ASSIGNED
Attachment #8373541 - Flags: review?(netzen)
Comment on attachment 8373541 [details] [diff] [review]
v1

Review of attachment 8373541 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/preferences/in-content/advanced.js
@@ +400,5 @@
>     * Clears the cache.
>     */
>    clearCache: function ()
>    {
> +    Services.cache2.clear();

This file should stay in sync with advanced.js.
Did something change in advanced.js recentlyt hat's not reflected in dxr?
http://dxr.mozilla.org/mozilla-central/source/browser/components/preferences/advanced.js#414
Attachment #8373541 - Flags: review?(netzen)
(Assignee)

Comment 3

4 years ago
I'm not sure I follow - you want the code be same?  Like: don't use Services and leave the {try catch}?
The code in in content preferences should match the code in normal preferences. If you want to make this change, then it should be done in both places and not only one place.
(Assignee)

Comment 5

4 years ago
Got it.  New patch will come.  Thanks.
(Assignee)

Comment 6

4 years ago
Created attachment 8375945 [details] [diff] [review]
v2
Attachment #8373541 - Attachment is obsolete: true
Attachment #8375945 - Flags: review?(netzen)
Attachment #8375945 - Flags: review?(netzen) → review+
https://hg.mozilla.org/mozilla-central/rev/7ec73b94e194
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.