Closed Bug 968684 Opened 6 years ago Closed 6 years ago
Add Makefile for homescreen app
46 bytes, text/x-github-pull-request
|Details | Review|
add a makefile for homescreen and migrate homescreen related code from applications-data.js and webapp-zip.js
Assignee: nobody → yurenju.mozilla
WIP: https://github.com/yurenju/gaia/commit/5ec4388b68da31519175f1a69bf0daea46dd7365 since homescreen use webapp-manifests.js to get all manifests of apps, I'm going to refactor communications app first because comm. app use webapp-manifests.js to get their own manifest file.
high resolution icon doesn't apply to homescreen when first launch, we should fix it for build script part.
last one for app-makefile refactoring! I also filed a follow up bug 972755 to store preload apps data from DISTRIBUTION_DIR/temp to build_stage/preload-app-data/.
Comment on attachment 8376114 [details] [review] github PR: https://github.com/mozilla-b2g/gaia/pull/16283 Discussed offline. Damn you svoperapps!
Comment on attachment 8376114 [details] [review] github PR: https://github.com/mozilla-b2g/gaia/pull/16283 refactored this refactoring code \o/ I commited for each your comment on github, those will be squashed to one commit if get r+
Comment on attachment 8376114 [details] [review] github PR: https://github.com/mozilla-b2g/gaia/pull/16283 Please manually confirm both old script and new script passes the test, before merging the pull request. Thank you, nice work!
Attachment #8376114 - Flags: review?(timdream) → review+
waiting for travis-ci.
travis-ci: https://travis-ci.org/mozilla-b2g/gaia/builds/19100087 merged. https://github.com/mozilla-b2g/gaia/commit/b85725cac0fc0f76fef2366055c3e55834f261d0
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Duplicate of this bug: 972755
Component: Gaia → Gaia::Build
You need to log in before you can comment on or make changes to this bug.