Closed
Bug 968689
Opened 11 years ago
Closed 11 years ago
Netd BandwidthController sets costlyAlert to invalid quota
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(blocking-b2g:1.3T+, b2g-v1.3T fixed)
| Tracking | Status | |
|---|---|---|
| b2g-v1.3T | --- | fixed |
People
(Reporter: albert, Assigned: albert)
References
Details
Attachments
(2 files)
|
2.18 KB,
patch
|
vchang
:
review+
|
Details | Diff | Splinter Review |
|
2.24 KB,
patch
|
vchang
:
review+
|
Details | Diff | Splinter Review |
Usage alarms in NetworkStats API use netd costlyAlerts to set quota and fire a message when netd notifies the API. As we can see in:
https://www.codeaurora.org/cgit/quic/la/platform/system/netd/tree/BandwidthController.cpp?h=b2g_ics_1.2#n870
When alertBytes is not null, so at least one alert has been set, alertBytes is not updated with desired quota bytes until the updateQuota has been called. That means quota is updated with a wrong value.
For the user it means that alarms are triggered at a wrong threshold values, for example:
- User sets an alarm at 500B.
- User sets an alarm at 700B.
- After some data transfer, user has consumed 600B.
- The first alarm is triggered.
- NetworkStats API sets the next alert quota at 100B, but BandwidthController sets old quota value to 500.
- The second alarm is triggered at 1000B, what is wrong.
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → acperez
|
|
||
Updated•11 years ago
|
blocking-b2g: --- → 1.3?
|
|
||
Comment 1•11 years ago
|
||
nominating to v1.3? since it is an issue related to NetworkStats API already uplifted to v1.3. Thanks!
|
|
||
Updated•11 years ago
|
blocking-b2g: 1.3? → 1.3+
|
|
Assignee | |
Comment 2•11 years ago
|
||
Remove netd alarm before adding the new one.
Attachment #8373175 -
Flags: review?(vchang)
|
|
Assignee | |
Comment 3•11 years ago
|
||
Attachment #8374643 -
Flags: review?(vchang)
|
|
||
Comment 4•11 years ago
|
||
Hi Vincent, could you please help us with the reviews?. Many Thanks!
Flags: needinfo?(vchang)
|
||
Comment 6•11 years ago
|
||
Comment on attachment 8373175 [details] [diff] [review]
Patch
Review of attachment 8373175 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, thank you.
Attachment #8373175 -
Flags: review?(vchang) → review+
|
|
||
Updated•11 years ago
|
Attachment #8374643 -
Flags: review?(vchang) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
|
||
Comment 8•11 years ago
|
||
Patch needed for Tarako version, asking for 1.3t?
blocking-b2g: 1.3? → 1.3T?
|
||
Comment 9•11 years ago
|
||
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S1 (14feb)
|
|
||
Comment 11•11 years ago
|
||
traige: 1.3T+ to get this into tarako for usage app memory saving
blocking-b2g: 1.3T? → 1.3T+
|
||
Comment 12•11 years ago
|
||
status-b2g-v1.3T:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•