Update test_receive_active_sync_email to check for incoming notification

RESOLVED FIXED

Status

P2
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: zcampbell, Assigned: viorela)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
For parity with QA smoketests, update this test to wait for the system notification of incoming email:

After setting up the email account, go back to the homescreen app and then use `EmailUtil().send` to send the email.

Wait for the email app's notification then tap it to open the Email app.
Verify that the sent email is now received.

Remove the `tap_subject`and following steps as they are now redundant.
(Assignee)

Updated

5 years ago
Assignee: nobody → viorela.ioia
(Assignee)

Comment 1

5 years ago
Created attachment 8406858 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/18328

Zac, can you take a look over the pull I opened? It is not ready for review yet, I need an overall opinion or/and suggestions, to make sure I'm on the good way :) I'll update it afterwards. Thanks!
Attachment #8406858 - Flags: feedback?(zcampbell)
(Reporter)

Comment 2

5 years ago
Comment on attachment 8406858 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/18328

couple of nits but otherwise it looks good.
Attachment #8406858 - Flags: feedback?(zcampbell) → feedback-
(Assignee)

Updated

5 years ago
Attachment #8406858 - Flags: feedback- → review?(zcampbell)
(Reporter)

Comment 3

5 years ago
Comment on attachment 8406858 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/18328

r+, works very nicely!
Attachment #8406858 - Flags: review?(zcampbell) → review+
(Reporter)

Comment 4

5 years ago
Merged:
https://github.com/mozilla-b2g/gaia/commit/2aabbcddcc6b560c6812a27d3652c4e8098a7314
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
See Also: → bug 1002342
(Reporter)

Comment 5

5 years ago
Reverted this becuase I was unhappy with a part of the commit:
https://github.com/mozilla-b2g/gaia/commit/109489265cad187582326015c9c6de6d4411f72d

Part of my fault for merging it.

Let's split the bit with tap_account_prefs_next(value) into two separate steps rather than have conditions in them.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 6

5 years ago
Created attachment 8413629 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/18735
Attachment #8406858 - Attachment is obsolete: true
Attachment #8413629 - Flags: review?(zcampbell)
(Reporter)

Comment 7

5 years ago
Comment on attachment 8413629 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/18735

r-, move one wait and also the test is failing (possibly failing without this pull request)
Attachment #8413629 - Flags: review?(zcampbell) → review-
(Assignee)

Comment 8

5 years ago
Comment on attachment 8413629 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/18735

The test fails because of a voicemail notification appears, next to the email notification. It is not related to the changes in my pull request.
Attachment #8413629 - Flags: review- → review?(zcampbell)
(Reporter)

Comment 9

5 years ago
Comment on attachment 8413629 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/18735

r-, `check_for_emails_interval` usage doesn't make sense
Attachment #8413629 - Flags: review?(zcampbell) → review-
(Assignee)

Updated

5 years ago
Attachment #8413629 - Flags: review- → review?(zcampbell)
(Reporter)

Comment 10

5 years ago
Comment on attachment 8413629 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/18735

r-, check_for_emails_interval is still not right
Attachment #8413629 - Flags: review?(zcampbell) → review-
(Assignee)

Updated

5 years ago
Attachment #8413629 - Flags: review- → review?(zcampbell)
(Reporter)

Comment 11

5 years ago
Comment on attachment 8413629 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/18735

r+
Attachment #8413629 - Flags: review?(zcampbell) → review+
(Reporter)

Comment 12

5 years ago
Merged:
https://github.com/mozilla-b2g/gaia/commit/feef47764b9ae49fa5cc28a07186db7905481297
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.