968744 - Update test_receive_active_sync_email to check for incoming notification

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P2)

Description

[Zac C (:zac)]

For parity with QA smoketests, update this test to wait for the system notification of incoming email:

After setting up the email account, go back to the homescreen app and then use `EmailUtil().send` to send the email.

Wait for the email app's notification then tap it to open the Email app.
Verify that the sent email is now received.

Remove the `tap_subject`and following steps as they are now redundant.

Comment 1

[Viorela Ioia [:viorela]]

Attachment: Github PR: https://github.com/mozilla-b2g/gaia/pull/18328

Zac, can you take a look over the pull I opened? It is not ready for review yet, I need an overall opinion or/and suggestions, to make sure I'm on the good way :) I'll update it afterwards. Thanks!

Comment 2

[Zac C (:zac)]

Comment on attachment 8406858 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/18328

couple of nits but otherwise it looks good.

Comment 3

[Zac C (:zac)]

Comment on attachment 8406858 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/18328

r+, works very nicely!

Comment 4

[Zac C (:zac)]

Merged:
https://github.com/mozilla-b2g/gaia/commit/2aabbcddcc6b560c6812a27d3652c4e8098a7314

Comment 5

[Zac C (:zac)]

Reverted this becuase I was unhappy with a part of the commit:
https://github.com/mozilla-b2g/gaia/commit/109489265cad187582326015c9c6de6d4411f72d

Part of my fault for merging it.

Let's split the bit with tap_account_prefs_next(value) into two separate steps rather than have conditions in them.

Comment 6

[Viorela Ioia [:viorela]]

Attachment: Github PR: https://github.com/mozilla-b2g/gaia/pull/18735

Comment 7

[Zac C (:zac)]

Comment on attachment 8413629 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/18735

r-, move one wait and also the test is failing (possibly failing without this pull request)

Comment 8

[Viorela Ioia [:viorela]]

Comment on attachment 8413629 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/18735

The test fails because of a voicemail notification appears, next to the email notification. It is not related to the changes in my pull request.

Comment 9

[Zac C (:zac)]

Comment on attachment 8413629 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/18735

r-, `check_for_emails_interval` usage doesn't make sense

Comment 10

[Zac C (:zac)]

Comment on attachment 8413629 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/18735

r-, check_for_emails_interval is still not right

Comment 11

[Zac C (:zac)]

Comment on attachment 8413629 [details] [review]
Github PR: https://github.com/mozilla-b2g/gaia/pull/18735

r+

Comment 12

[Zac C (:zac)]

Merged:
https://github.com/mozilla-b2g/gaia/commit/feef47764b9ae49fa5cc28a07186db7905481297