968751 - Write a test to open long-press power button menu

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P1)

Description

[Zac C (:zac)]

For parity with manual QA smoketests, write a test case to activate and validate the longpress power menu. Moztrap: https://moztrap.mozilla.org/manage/case/1330/

Add a method into GaiaDevice class to trigger the javascript command that exposes the menu.

At the end of the test instead of powering off the device, tap Cancel to return to Homescreen.

Comment 1

[Florin Strugariu [:Bebe]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16175

Comment 2

[Viorela Ioia [:viorela]]

Comment on attachment 8374082 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16175

Comments in the pull request

Comment 3

[Zac C (:zac)]

Comment on attachment 8374082 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16175

r+ just after removing the "APZ" option

Comment 4

[Florin Strugariu [:Bebe]]

:zac I updated the Pull

Comment 5

[Zac C (:zac)]

https://github.com/mozilla-b2g/gaia/commit/16039b36b6125698d8a8e3579b49ba35b92a3d10

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Please set the appropriate status flag when landing v1.3.

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

1.3/1.3t: https://github.com/mozilla-b2g/gaia/commit/2fdeedf457a54b5140a84324db187e885134c9cc

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

And it was reverted on 1.3: https://github.com/mozilla-b2g/gaia/commit/100a159af11281d965e9d70d0f3d3111a38775ee

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I don't know why the revert commit wasn't being merged to 1.3t, but I will manually revert that on 1.3t as this cause Travis-CI build error on the branch.

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

After looking into the log, I should probably leave it and wait for Ryan to merge 1.3 to 1.3t tomorrow.

Set a needinfo here.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

There's no need for a needinfo (and accompanying bugspam). I do the merges daily, but with yesterday's github issues (you saw dev-b2g, right?), I wasn't able to.

Comment 12

[Zac C (:zac)]

This test doesn't need to be patched to v1.3 as far as I'm concerned. Not sure who's driving it to be uplifted?

Comment 13

[Bob Silverberg [:bsilverberg]]

There was a separate bug about backporting this to v1.3. I'm not sure how this old bug got involved. In any case we are no longer going to do that, so I will close this as already fixed.

Comment 14

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Zac, The patch showed up in the branch but the commit was commented on this bug. It's also responsible of errors on Travis-CI yesterday. That why I commented on this bug to put the necessary commits here, for data-keeping.

Bob, what is the "separate bug"? If you are landing a patch in another bug, make sure the commit message is about the other bug. Please follow the landing rules and save some time of your peers.