968806 - Touching WebIDL.py, Codegen.py or Configuration.py does not cause the WebIDL bindings to be regenerated

Status: RESOLVED INVALID

(Firefox Build System :: General, defect)

Description

[(no longer active)]

STR:

./mach build
touch dom/bindings/parser/WebIDL.py dom/bindings/Codegen.py dom/bindings/Configuration.py
./mach build

Found this out when working on bug 968643.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Did you just touch them, or change something?  I think the setup gps put in place in bug 928195 uses file hashes, not file dates, to decide whether the files changed...

Comment 2

[Gregory Szorc [:gps]]

No-op is no-op:

gps@gps-mbp:~/src/firefox$ mach build -v dom/bindings/export
 0:00.08 /usr/bin/make -C /Users/gps/src/firefox/obj-firefox.noindex -j8 -s backend.RecursiveMakeBackend
 0:00.51 /usr/bin/make -C dom/bindings -j8 export
 0:00.53 /Applications/Xcode.app/Contents/Developer/usr/bin/make -C test export
 0:00.53 make[1]: Nothing to be done for `export'.
Your build was successful!

touching a .py file invokes WebIDL processing:

gps@gps-mbp:~/src/firefox$ touch dom/bindings/parser/WebIDL.py
gps@gps-mbp:~/src/firefox$ mach build -v dom/bindings/export
 0:00.09 /usr/bin/make -C /Users/gps/src/firefox/obj-firefox.noindex -j8 -s backend.RecursiveMakeBackend
 0:00.51 /usr/bin/make -C dom/bindings -j8 export
 0:00.53 /Users/gps/src/firefox/obj-firefox.noindex/_virtualenv/bin/python -m mozbuild.action.webidl /Users/gps/src/firefox/dom/bindings
 0:03.01 /Applications/Xcode.app/Contents/Developer/usr/bin/make -C test export
 0:03.02 make[1]: Nothing to be done for `export'.
Your build was successful!

I'm unable to reproduce the bug.

Please provide more details about what isn't working.

Comment 3

[(no longer active)]

Ah, I was fooled by this setup it seems.  Sorry for the false alarm.