Closed Bug 968819 Opened 6 years ago Closed 6 years ago

HOST_OS_ARCH is different from OS_ARCH on BSDs

Categories

(Firefox Build System :: General, defect)

All
FreeBSD
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla30

People

(Reporter: jbeich, Assigned: jbeich)

References

Details

Attachments

(1 file, 2 obsolete files)

Attached patch convert names (obsolete) — Splinter Review
+++ This bug was initially created as a clone of Bug #959477 +++

When building on BSDs

1000    HOST_OS_ARCH=`echo $host_os | sed -e 's|/|_|g'`

while OS_ARCH takes `uname -s`-style values since bug 959477

982         dragonfly*)   OS_ARCH=DragonFly OS_TARGET=DragonFly ;;
983         freebsd*)     OS_ARCH=FreeBSD OS_TARGET=FreeBSD ;;
984         netbsd*)      OS_ARCH=NetBSD OS_TARGET=NetBSD ;;
985         openbsd*)     OS_ARCH=OpenBSD OS_TARGET=OpenBSD ;;

For example, on FreeBSD I have:

  HOST_OS_ARCH = freebsd11.0
  OS_ARCH = FreeBSD
Attachment #8371495 - Flags: review?(mh+mozilla)
Attached patch convert names, v2 (obsolete) — Splinter Review
May as well add missing GNU platforms because on Debian I get

  HOST_OS_ARCH = kfreebsd11.0-gnu
  OS_ARCH = GNU_kFreeBSD
Attachment #8371495 - Attachment is obsolete: true
Attachment #8371495 - Flags: review?(mh+mozilla)
Attachment #8371509 - Flags: review?(mh+mozilla)
Comment on attachment 8371509 [details] [diff] [review]
convert names, v2

Review of attachment 8371509 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/configure.in
@@ +4371,5 @@
>                  ;;
>              WINNT)
>                  ICU_TARGET=MSYS/MSVC
>                  ;;
> +            DragonFly|FreeBSD|NetBSD|OpenBSD)

kFreeBSD is missing here (it was obviously caught with the previous wildcards ; i'm not sure it's a working configuration, but at least that matches what we have now).
Attachment #8371509 - Flags: review?(mh+mozilla) → review+
Attachment #8371509 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e1dfcb9ac6c8
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.